GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v13.x backport] src: create a getter for kernel version by juanarbol · Pull Request #32166 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Mar 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Backport-PR-URL: #31732

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. v13.x labels Mar 10, 2020
@juanarbol
juanarbol changed the base branch from v13.x to v13.x-staging March 10, 2020 03:35
@juanarbol
juanarbol force-pushed the juanarbol/os-kernel-version branch from 34a13d0 to 693e350 Compare March 10, 2020 03:51
@juanarbol juanarbol changed the title [backport v13.x] src: create a getter for kernel version [v13.x backport] src: create a getter for kernel version Mar 10, 2020
@juanarbol
src: create a getter for kernel version
373eb4c
@juanarbol
juanarbol force-pushed the juanarbol/os-kernel-version branch from 693e350 to 373eb4c Compare March 10, 2020 04:02
addaleax
addaleax approved these changes Mar 10, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29701/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 10, 2020
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@juanarbol @MylesBorins
src: create a getter for kernel version
258a80d 
Backport-PR-URL: #32166
PR-URL: #31732
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins

MylesBorins commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

258a80d
juanarbol reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins closed this Mar 10, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@juanarbol @targos
src: create a getter for kernel version
ecf359c 
Backport-PR-URL: nodejs#32166
PR-URL: nodejs#31732
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @targos
src: create a getter for kernel version
394487e 
Backport-PR-URL: #32166
PR-URL: #31732
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juanarbol
juanarbol deleted the juanarbol/os-kernel-version branch January 19, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@juanarbol @nodejs-github-bot @MylesBorins @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.