GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps,doc: move openssl maintenance guide to doc by sam-github · Pull Request #32209 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Mar 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 11, 2020
@sam-github sam-github mentioned this pull request Mar 11, 2020
todo: update to openssl 1.1.1e on March 17th #32210
Closed
cjihrig
cjihrig approved these changes Mar 11, 2020
View reviewed changes
richardlau
richardlau approved these changes Mar 11, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 11, 2020
View reviewed changes
@sam-github
sam-github force-pushed the maintaining-openssl branch from e8ac0c3 to f1b7027 Compare March 12, 2020 16:59
@sam-github
deps,doc: move openssl maintenance guide to doc
722f2fe 
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
@sam-github
sam-github force-pushed the maintaining-openssl branch from f1b7027 to 722f2fe Compare March 12, 2020 17:19
@jasnell

jasnell commented Mar 12, 2020

Copy link
Copy Markdown
Member

Can we fasttrack this?
sam-github reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Mar 13, 2020
@sam-github

sam-github commented Mar 13, 2020

Copy link
Copy Markdown
Contributor Author

I'm OK with it, not sure how many +1s we need.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Mar 17, 2020
@sam-github @jasnell
deps,doc: move openssl maintenance guide to doc
5eb85dd 
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Mar 17, 2020

Copy link
Copy Markdown
Member

Landed in 5eb85dd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Mar 17, 2020
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@sam-github @MylesBorins
deps,doc: move openssl maintenance guide to doc
7c8ebd0 
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
v13.12.0 proposal #32376
Merged
@sam-github
sam-github deleted the maintaining-openssl branch March 20, 2020 21:34
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@sam-github @MylesBorins
deps,doc: move openssl maintenance guide to doc
11ed1e6 
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@sam-github @targos
deps,doc: move openssl maintenance guide to doc
0e92244 
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sam-github @jasnell @cjihrig @richardlau @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.