GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use Promise.all() in test-hash-seed by Trott · Pull Request #32273 · nodejs/node

Conversation

@Trott

@Trott Trott commented Mar 14, 2020

Copy link
Copy Markdown
Member

We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Mar 14, 2020
@Trott

Trott commented Mar 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12864/ ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Mar 15, 2020
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 15, 2020
tniessen
tniessen approved these changes Mar 15, 2020
View reviewed changes
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment thread test/pummel/test-hash-seed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment thread test/pummel/test-hash-seed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment thread test/pummel/test-hash-seed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment thread test/pummel/test-hash-seed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 17, 2020
View reviewed changes
@Trott

Trott commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12912/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
antsmartian
antsmartian approved these changes Mar 17, 2020
View reviewed changes

@antsmartian antsmartian left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott added a commit to Trott/io.js that referenced this pull request Mar 18, 2020
@Trott
test: use Promise.all() in test-hash-seed
1a3c747 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: nodejs#32273
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@Trott

Trott commented Mar 18, 2020

Copy link
Copy Markdown
Member Author

Landed in 1a3c747
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Mar 18, 2020
@Trott
Trott force-pushed the pummel-hash-seed branch from e8ba9f1 to 1a3c747 Compare March 18, 2020 01:30
@Trott
Trott deleted the pummel-hash-seed branch March 18, 2020 01:30
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@Trott @MylesBorins
test: use Promise.all() in test-hash-seed
7d1e170 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
v13.12.0 proposal #32376
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: use Promise.all() in test-hash-seed
05fd160 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: use Promise.all() in test-hash-seed
8dbd7cf 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@tniessen tniessen tniessen approved these changes
+2 more reviewers
@targos targos targos approved these changes
@antsmartian antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @jasnell @antsmartian @targos @tniessen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.