GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: don't emit 'finish' after 'error' by ronag · Pull Request #32276 · nodejs/node

Conversation

@ronag

@ronag ronag commented Mar 14, 2020

Copy link
Copy Markdown
Member

An edge case could emit 'finish' after 'error'.

Refs: #28710

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. stream Issues and PRs related to Node.js streams. labels Mar 14, 2020
@ronag
http: don't emit 'finish' after 'error'
c67b545
@ronag
ronag force-pushed the http-error-finish branch from ace1aec to c67b545 Compare March 14, 2020 23:55
@ronag ronag removed the stream Issues and PRs related to Node.js streams. label Mar 14, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29838/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 16, 2020
View reviewed changes
@ronag ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 16, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29867/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Mar 18, 2020
View reviewed changes
@ronag

ronag commented Mar 18, 2020

Copy link
Copy Markdown
Member Author

Landed in a9270dc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag closed this Mar 18, 2020
ronag added a commit that referenced this pull request Mar 18, 2020
@ronag
http: don't emit 'finish' after 'error'
a9270dc 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@ronag @MylesBorins
http: don't emit 'finish' after 'error'
720a2e2 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
v13.12.0 proposal #32376
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@ronag @MylesBorins
http: don't emit 'finish' after 'error'
ef32069 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos

targos commented Apr 22, 2020

Copy link
Copy Markdown
Member

is this safe to land on v12 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag

ronag commented Apr 22, 2020

Copy link
Copy Markdown
Member Author

@targos: I think so.
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Apr 22, 2020
@ronag @targos
http: don't emit 'finish' after 'error'
cf47bb9 
PR-URL: #32276
Refs: #28710
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ronag @nodejs-github-bot @targos @jasnell @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.