GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: expand ASAN acronym in configure help by sam-github · Pull Request #32325 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Mar 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There is lots of space to expand this not-so-well-known acronym in the
option usage message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Mar 17, 2020
cjihrig
cjihrig approved these changes Mar 17, 2020
View reviewed changes
richardlau
richardlau approved these changes Mar 17, 2020
View reviewed changes
mmarchini
mmarchini approved these changes Mar 17, 2020
View reviewed changes
trivikr
trivikr approved these changes Mar 18, 2020
View reviewed changes
lpinca
lpinca approved these changes Mar 18, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 18, 2020
View reviewed changes
mmarchini
mmarchini reviewed Mar 19, 2020
View reviewed changes
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sam-github
sam-github force-pushed the asan-expand branch from 2b79a0d to 1cb8b85 Compare March 19, 2020 16:02
@sam-github
build: expand ASAN acronym in configure help
4ca6f1b 
There is lots of space to expand this not-so-well-known acronym in the
option usage message.
@sam-github
sam-github force-pushed the asan-expand branch from 1cb8b85 to 4ca6f1b Compare March 20, 2020 18:25
@sam-github

sam-github commented Mar 20, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 131b50d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github closed this Mar 20, 2020
@sam-github
sam-github deleted the asan-expand branch March 20, 2020 21:29
sam-github added a commit that referenced this pull request Mar 20, 2020
@sam-github
build: expand ASAN acronym in configure help
131b50d 
There is lots of space to expand this not-so-well-known acronym in the
option usage message.

PR-URL: #32325
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@sam-github @MylesBorins
build: expand ASAN acronym in configure help
8ea5ffc 
There is lots of space to expand this not-so-well-known acronym in the
option usage message.

PR-URL: #32325
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
v13.12.0 proposal #32376
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@sam-github @targos
build: expand ASAN acronym in configure help
a3848e5 
There is lots of space to expand this not-so-well-known acronym in the
option usage message.

PR-URL: #32325
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@mmarchini mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@sam-github @jasnell @lpinca @cjihrig @mmarchini @richardlau @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.