GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: delete CallbackInfo when cleared from cleanup hook by addaleax · Pull Request #32405 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Mar 21, 2020

Copy link
Copy Markdown
Member

Fixes: #32400

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@addaleax
src: delete CallbackInfo when cleared from cleanup hook
70b6263 
Fixes: nodejs#32400
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Mar 21, 2020
@addaleax addaleax mentioned this pull request Mar 21, 2020
Possible undefined behavior on buffer's CallbackInfo #32400
Closed
mmarchini
mmarchini approved these changes Mar 21, 2020
View reviewed changes

@mmarchini mmarchini left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will run ASAN tests tomorrow to confirm, but I think it should fix it. Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@addaleax

addaleax commented Mar 21, 2020

Copy link
Copy Markdown
Member Author

@mmarchini Fwiw, I could reproduce the leak reported by ASAN with valgrind, and valgrind doesn’t report it anymore :)
gengjiawen reacted with thumbs up emoji mmarchini, gengjiawen, and himself65 reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gengjiawen
gengjiawen approved these changes Mar 21, 2020
View reviewed changes
targos
targos approved these changes Mar 21, 2020
View reviewed changes
@addaleax addaleax mentioned this pull request Mar 21, 2020
test: use InitializeNodeWithArgs in cctest #32406
Closed
3 tasks done
cjihrig
cjihrig approved these changes Mar 21, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 21, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29968/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 22, 2020
View reviewed changes
mmarchini pushed a commit that referenced this pull request Mar 23, 2020
@addaleax @mmarchini
src: delete CallbackInfo when cleared from cleanup hook
678e1be 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mmarchini

mmarchini commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

Landed in 678e1be
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmarchini mmarchini closed this Mar 23, 2020
@addaleax
addaleax deleted the buffer-callback branch March 23, 2020 18:11
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@addaleax @MylesBorins
src: delete CallbackInfo when cleared from cleanup hook
bd998bc 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
v13.12.0 proposal #32376
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@addaleax @MylesBorins
src: delete CallbackInfo when cleared from cleanup hook
2fe351f 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
src: delete CallbackInfo when cleared from cleanup hook
7aa2ee2 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
+2 more reviewers
@targos targos targos approved these changes
@mmarchini mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible undefined behavior on buffer's CallbackInfo

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@addaleax @nodejs-github-bot @mmarchini @jasnell @targos @cjihrig @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.