GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove AsyncWrap mentions from async_hooks.md by puzpuzpuz · Pull Request #33249 · nodejs/node

Conversation

@puzpuzpuz

@puzpuzpuz puzpuzpuz commented May 5, 2020

Copy link
Copy Markdown
Member

AsyncWrap is a private API and should not be mentioned in the documentation. For some reasons, it was there for ages.

cc @nodejs/async_hooks

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@puzpuzpuz
doc: remove AsyncWrap mentions from async_hooks.md
44d90fb
AsyncWrap is a private API and should not be mentioned
in the documentation.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels May 5, 2020
addaleax
addaleax approved these changes May 5, 2020
View reviewed changes
targos
targos approved these changes May 6, 2020
View reviewed changes
legendecas
legendecas approved these changes May 6, 2020
View reviewed changes
Flarna
Flarna approved these changes May 6, 2020
View reviewed changes
benjamingr
benjamingr approved these changes May 6, 2020
View reviewed changes
jasnell
jasnell approved these changes May 6, 2020
View reviewed changes
@addaleax

addaleax commented May 7, 2020

Copy link
Copy Markdown
Member

Landed in dab51dd

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax addaleax closed this May 7, 2020
addaleax pushed a commit that referenced this pull request May 7, 2020
@puzpuzpuz @addaleax
doc: remove AsyncWrap mentions from async_hooks.md
dab51dd
AsyncWrap is a private API and should not be mentioned
in the documentation.

PR-URL: #33249
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@puzpuzpuz
puzpuzpuz deleted the doc/remove-asyncwrap branch May 9, 2020 11:41
codebytere pushed a commit that referenced this pull request May 11, 2020
@puzpuzpuz @codebytere
doc: remove AsyncWrap mentions from async_hooks.md
dab5c38
AsyncWrap is a private API and should not be mentioned
in the documentation.

PR-URL: #33249
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
v14.3.0 proposal #33452
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@puzpuzpuz @codebytere
doc: remove AsyncWrap mentions from async_hooks.md
2262962
AsyncWrap is a private API and should not be mentioned
in the documentation.

PR-URL: #33249
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
v12.18.1 proposal #33811
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@benjamingr benjamingr benjamingr approved these changes
@legendecas legendecas legendecas approved these changes
@Flarna Flarna Flarna approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@puzpuzpuz @addaleax @jasnell @benjamingr @targos @legendecas @Flarna @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.