GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: add primordials to arguments comment by danbev · Pull Request #33318 · nodejs/node

Conversation

@danbev

@danbev danbev commented May 9, 2020

Copy link
Copy Markdown
Contributor

This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@danbev
src: add primordials to arguments comment
1120148 
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.
addaleax
addaleax approved these changes May 9, 2020
View reviewed changes
cjihrig
cjihrig approved these changes May 9, 2020
View reviewed changes
BridgeAR
BridgeAR approved these changes May 9, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 9, 2020
trivikr
trivikr approved these changes May 11, 2020
View reviewed changes
himself65
himself65 approved these changes May 11, 2020
View reviewed changes
@danbev danbev removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 11, 2020
@nodejs-github-bot

nodejs-github-bot commented May 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31285/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danbev added a commit that referenced this pull request May 13, 2020
@danbev
src: add primordials to arguments comment
e1b90be 
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

PR-URL: #33318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@danbev

danbev commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

Landed in e1b90be.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danbev danbev closed this May 13, 2020
@danbev
danbev deleted the add-primordials-command branch May 13, 2020 07:24
codebytere pushed a commit that referenced this pull request May 16, 2020
@danbev @codebytere
src: add primordials to arguments comment
d292633 
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

PR-URL: #33318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
v14.3.0 proposal #33452
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@danbev @codebytere
src: add primordials to arguments comment
1f159e4 
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

PR-URL: #33318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
v12.18.1 proposal #33811
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@himself65 himself65 himself65 approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@danbev @nodejs-github-bot @addaleax @cjihrig @BridgeAR @himself65 @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.