GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update to ICU 67.1 by targos · Pull Request #33324 · nodejs/node

Conversation

@targos

@targos targos commented May 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

V8 8.4 will require it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and jeudesprits reacted with thumbs up emoji bricss reacted with heart emoji bricss reacted with rocket emoji bricss reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • ❤️ 1 reaction
  • 🚀 1 reaction
  • 👀 1 reaction
@targos
targos requested review from ryzokuken and srl295 May 9, 2020 11:43
ryzokuken
ryzokuken approved these changes May 9, 2020
View reviewed changes

@ryzokuken ryzokuken left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau

richardlau commented May 9, 2020

Copy link
Copy Markdown
Member

tools/icu/current_ver.dep should be updated: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#how-to-upgrade-icu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 9, 2020

Copy link
Copy Markdown
Member Author

Am I supposed to compute the md5 myself?
srl295 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos added 2 commits May 9, 2020 14:15
@targos
deps: update to ICU 67.1
d92b38f 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1
@targos
fixup! deps: update to ICU 67.1
112386c
@targos
targos force-pushed the icu-67.1 branch from 9fa0d1c to 112386c Compare May 9, 2020 12:16
@nodejs-github-bot

nodejs-github-bot commented May 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31253/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 9, 2020
srl295
srl295 approved these changes May 9, 2020
View reviewed changes

@srl295 srl295 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta LGTM, code RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srl295

srl295 commented May 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • let me update the full-icu data so i don't break it again Post-Install Failure on node 12.16.2 full-icu-npm#46

in progress https://www.npmjs.com/package/icu4c-data
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented May 9, 2020

Copy link
Copy Markdown
Member

in progress https://www.npmjs.com/package/icu4c-data

I'm getting timeouts…again… trying to publish to npm. So it's not quite there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere

codebytere commented May 11, 2020

Copy link
Copy Markdown
Member

@targos does this close nodejs/Release#576? It was assigned to me per the last release meeting so i want to make sure i'm not duplicating work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 11, 2020

Copy link
Copy Markdown
Member Author

@codebytere I don't know. I asked the same question to @srl295 (#33337 (comment)) 15 minutes ago 😄
codebytere reacted with thumbs up emoji codebytere reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented May 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@targos does this close nodejs/Release#576? It was assigned to me per the last release meeting so i want to make sure i'm not duplicating work.

Ugh. did not see this, I could have incorporated this into the data.

No, that bug shows as fixed in 68 not 67.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos added a commit that referenced this pull request May 12, 2020
@targos
deps: update to ICU 67.1
cfec30f 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: #33324
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
@targos

targos commented May 12, 2020

Copy link
Copy Markdown
Member Author

Landed in cfec30f
srl295 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this May 12, 2020
@targos
targos deleted the icu-67.1 branch May 12, 2020 07:58
@targos targos added backport-open-v12.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels May 12, 2020
@srl295 srl295 mentioned this pull request May 12, 2020
[v12.x] deps: update to ICU 67.1 #33337
Closed
codebytere pushed a commit that referenced this pull request May 16, 2020
@targos @codebytere
deps: update to ICU 67.1
331f0b3 
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: #33324
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
v14.3.0 proposal #33452
Merged
@addaleax addaleax added backported-to-v12.x and removed backport-open-v12.x labels Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 approved these changes
+1 more reviewer
@ryzokuken ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@targos @richardlau @nodejs-github-bot @srl295 @codebytere @ryzokuken @addaleax @BridgeAR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.