GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix test-net-throttle by Trott · Pull Request #33329 · nodejs/node

Conversation

@Trott

@Trott Trott commented May 9, 2020

Copy link
Copy Markdown
Member

Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label May 9, 2020
@Trott

Trott commented May 9, 2020

Copy link
Copy Markdown
Member Author

Relevant CI run is: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14181/

Pummel tests otherwise don't get run in CI, so only the linter and the above job are relevant.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 9, 2020

Copy link
Copy Markdown
Member Author

The test passed in CI. First time in something like two weeks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott mentioned this pull request May 9, 2020
flaky test-net-throttle on daily master #33135
Closed
@Trott Trott added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label May 9, 2020
lpinca
lpinca approved these changes May 9, 2020
View reviewed changes
Comment thread test/pummel/test-net-throttle.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 9, 2020

Copy link
Copy Markdown
Member Author

Re-running relevant CI post-fixup commit: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14184/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 10, 2020
@Trott Trott mentioned this pull request May 10, 2020
tools: add debuglog eslint rule #32161
Closed
4 tasks done
juanarbol
juanarbol approved these changes May 10, 2020
View reviewed changes
@Trott

Trott commented May 10, 2020

Copy link
Copy Markdown
Member Author

This is basically the only thing that has kept node-daily-master from being green many days now.

Fast-track? 👍 here to approve if you're a Collaborator.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 10, 2020
@Trott
test: fix test-net-throttle
5ded044 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: nodejs#33135

PR-URL: nodejs#33329
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@Trott
Trott force-pushed the fix-test-net-throttle branch from d348f0c to 5ded044 Compare May 11, 2020 18:42
@Trott

Trott commented May 11, 2020

Copy link
Copy Markdown
Member Author

Landed in 5ded044
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 5ded044 into nodejs:master May 11, 2020
codebytere pushed a commit that referenced this pull request May 15, 2020
@Trott @codebytere
test: fix test-net-throttle
5b2cd44 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
v14.3.0 proposal #33452
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@Trott @codebytere
test: fix test-net-throttle
c459832 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
v12.18.1 proposal #33811
Merged
@Trott
Trott deleted the fix-test-net-throttle branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky test-net-throttle on daily master

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @lpinca @juanarbol @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.