GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix test-dns-idna2008 by Trott · Pull Request #33367 · nodejs/node

Conversation

@Trott

@Trott Trott commented May 12, 2020

Copy link
Copy Markdown
Member

The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use family option to force IPv4.

Hide white-space changes in the diff to ignore all the code moved to accommodate line-wrapping at 80 chars.

This failed in node-daily-master last night. I'd like to fast-track. Please 👍 here if you are a Collaborator and agree this could/should be fast-tracked.

00:03:31 not ok 11 internet/test-dns-idna2008
00:03:31   ---
00:03:31   duration_ms: 1.15
00:03:31   severity: fail
00:03:31   exitcode: 1
00:03:31   stack: |-
00:03:31     assert.js:103
00:03:31       throw new AssertionError(obj);
00:03:31       ^
00:03:31     
00:03:31     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:03:31     + actual - expected
00:03:31     
00:03:31     + '2a01:238:20a:202:1078::'
00:03:31     - '81.169.145.78'
00:03:31         at GetAddrInfoReqWrap.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/internet/test-dns-idna2008.js:32:10)
00:03:31         at GetAddrInfoReqWrap.callback (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/index.js:364:15)
00:03:31         at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:68:8) {
00:03:31       generatedMessage: true,
00:03:31       code: 'ERR_ASSERTION',
00:03:31       actual: '2a01:238:20a:202:1078::',
00:03:31       expected: '81.169.145.78',
00:03:31       operator: 'strictEqual'
00:03:31     }
00:03:31   ...
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label May 12, 2020
@Trott

Trott commented May 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Internet tests aren't run in our regular CI so here's a CI for internet tests run the same way we run them in node-daily-master: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14228/ ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label May 12, 2020
@Trott
Trott requested a review from bnoordhuis May 12, 2020 13:48
bnoordhuis
bnoordhuis approved these changes May 12, 2020
View reviewed changes
@Trott

Trott commented May 14, 2020

Copy link
Copy Markdown
Member Author

@nodejs/dns @nodejs/testing

(Hide whitespace in the diff because a lot of lines were moved to accommodate 80-char wrapping: https://github.com/nodejs/node/pull/33367/files?diff=unified&w=1)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 15, 2020
lpinca
lpinca approved these changes May 15, 2020
View reviewed changes
@Trott
test: fix test-dns-idna2008
23a61eb 
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: nodejs#33367
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the idna-again branch from f0e96e3 to 23a61eb Compare May 15, 2020 12:49
@Trott
Trott merged commit 23a61eb into nodejs:master May 15, 2020
@Trott

Trott commented May 15, 2020

Copy link
Copy Markdown
Member Author

Landed in 23a61eb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the idna-again branch May 15, 2020 12:49
codebytere pushed a commit that referenced this pull request May 16, 2020
@Trott @codebytere
test: fix test-dns-idna2008
d3e2fc8 
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: #33367
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
v14.3.0 proposal #33452
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@Trott @codebytere
test: fix test-dns-idna2008
c58fc62 
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: #33367
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
@Trott @codebytere
test: fix test-dns-idna2008
9f594be 
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: nodejs#33367
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
v12.18.1 proposal #33811
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @bnoordhuis @lpinca @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.