GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update dependencies for markdown linting by Trott · Pull Request #33412 · nodejs/node

Conversation

@Trott

@Trott Trott commented May 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

tools: update dependencies for markdown linting

Also:

doc: prepare 14.x changelog for remark update

Add a comment to disable a rule in the 14.x changelog that will be
needed once we update remark lint dependencies. This comment appears in
the other changelogs.

Refs: https://github.com/nodejs/remark-preset-lint-node/pull/89#issuecomment-628978791
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 15, 2020
@Trott Trott mentioned this pull request May 15, 2020
Bump lockfile-lint from 4.2.2 to 4.3.3 nodejs/remark-preset-lint-node#89
Closed
addaleax
addaleax approved these changes May 15, 2020
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 15, 2020
@Trott

Trott commented May 15, 2020

Copy link
Copy Markdown
Member Author

(Code changes here only get run in lint jobs, so full CI should be superfluous.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes May 15, 2020
View reviewed changes
Trott added 2 commits May 16, 2020 22:02
@Trott
doc: prepare 14.x changelog for remark update
bea0ee8 
Add a comment to disable a rule in the 14.x changelog that will be
needed once we update remark lint dependencies. This comment appears in
the other changelogs.

Refs: nodejs/remark-preset-lint-node#89 (comment)

PR-URL: nodejs#33412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott
tools: update dependencies for markdown linting
b3ca886 
PR-URL: nodejs#33412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott
Trott force-pushed the remark-lint@7 branch from 72fbcfe to b3ca886 Compare May 17, 2020 05:02
@Trott

Trott commented May 17, 2020

Copy link
Copy Markdown
Member Author

Landed in b46bbf2...b3ca886
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit b3ca886 into nodejs:master May 17, 2020
@Trott
Trott deleted the remark-lint@7 branch May 17, 2020 05:03
codebytere pushed a commit that referenced this pull request May 17, 2020
@Trott @codebytere
doc: prepare 14.x changelog for remark update
cc27949 
Add a comment to disable a rule in the 14.x changelog that will be
needed once we update remark lint dependencies. This comment appears in
the other changelogs.

Refs: nodejs/remark-preset-lint-node#89 (comment)

PR-URL: #33412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request May 17, 2020
@Trott @codebytere
tools: update dependencies for markdown linting
453affe 
PR-URL: #33412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
v14.3.0 proposal #33452
Merged
@codebytere codebytere added the dont-land-on-v12.x label Jun 7, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@Trott @codebytere
tools: update dependencies for markdown linting
03bbf6d 
PR-URL: #33412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
@Trott @codebytere
tools: update dependencies for markdown linting
e240d56 
PR-URL: nodejs#33412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
v12.18.1 proposal #33811
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @addaleax @richardlau @codebytere @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.