GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v10.x backport] inspector: more conservative minimum stack size by Flarna · Pull Request #33720 · nodejs/node

Conversation

@Flarna

@Flarna Flarna commented Jun 4, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We see crashes in some musl docker environments caused by stack overflow in inspector thread. This happens during signal handling which is used as fallback by musl-libc in case syscall membarrier is not allowed by the secprofile.

fyi @bnoordhuis - the initial PR was done by you

PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.

PR-URL: #27855
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Eugene Ostroukhov [email protected]
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Rich Trott [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol. v10.x labels Jun 4, 2020
@bnoordhuis @Flarna
inspector: more conservative minimum stack size
f05a7a4 
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.

Backport-PR-URL: nodejs#33720
PR-URL: nodejs#27855
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Flarna
Flarna force-pushed the min-thread-stack-size branch from ec1aeaa to f05a7a4 Compare June 4, 2020 05:57
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31714/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2020 •
edited by Flarna
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31715/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Jun 4, 2020
View reviewed changes
addaleax
addaleax approved these changes Jun 4, 2020
View reviewed changes
@Flarna Flarna added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 7, 2020
@datvong-wm

datvong-wm commented Jun 10, 2020

Copy link
Copy Markdown

Would also like this patch merged into v10.
dmikey reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna Flarna mentioned this pull request Jun 11, 2020
Release plan - v10.x Maintenance nodejs/Release#504
Closed
@Flarna

Flarna commented Jun 23, 2020

Copy link
Copy Markdown
Member Author

@nodejs/lts Any chance that we get this into a release?
LucasHocker reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Jun 23, 2020

Copy link
Copy Markdown
Member

@nodejs/lts Any chance that we get this into a release?

I'll try to include this in the next 10.x release.
Flarna reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32176/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32183/ (✔️)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@bnoordhuis @richardlau
inspector: more conservative minimum stack size
aaf2f82 
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.

Backport-PR-URL: #33720
PR-URL: #27855
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau

richardlau commented Jul 1, 2020

Copy link
Copy Markdown
Member

Landed in aaf2f82.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau closed this Jul 1, 2020
@Flarna
Flarna deleted the min-thread-stack-size branch July 1, 2020 14:40
This was referenced Jul 2, 2020
CI Relability 2020-07-02 JaneaSystems/nodejs-reliability#25
Open
CI Relability 2020-07-03 JaneaSystems/nodejs-reliability#26
Open
CI Relability 2020-07-04 JaneaSystems/nodejs-reliability#27
Open
CI Relability 2020-07-05 JaneaSystems/nodejs-reliability#28
Open
CI Relability 2020-07-06 JaneaSystems/nodejs-reliability#29
Open
CI Relability 2020-07-07 JaneaSystems/nodejs-reliability#30
Open
CI Relability 2020-07-08 JaneaSystems/nodejs-reliability#31
Open
This was referenced Jul 9, 2020
CI Relability 2020-07-09 JaneaSystems/nodejs-reliability#32
Open
CI Relability 2020-07-10 JaneaSystems/nodejs-reliability#33
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Flarna @nodejs-github-bot @datvong-wm @richardlau @bnoordhuis @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.