GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: guard against nullptr deref in TimerWrapHandle::Stop by addaleax · Pull Request #34460 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member

Refs: #34454

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and lin7sh reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@addaleax
src: guard against nullptr deref in TimerWrapHandle::Stop
4d35330 
Refs: nodejs#34454
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout(). labels Jul 21, 2020
@addaleax addaleax mentioned this pull request Jul 21, 2020
build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot #34454
Closed
4 tasks done
gengjiawen
gengjiawen approved these changes Jul 21, 2020
View reviewed changes
richardlau
richardlau approved these changes Jul 21, 2020
View reviewed changes
jasnell
jasnell approved these changes Jul 21, 2020
View reviewed changes
devnexen
devnexen approved these changes Jul 21, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2020 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32442/ (:green_heart:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 21, 2020
@jasnell

jasnell commented Jul 21, 2020

Copy link
Copy Markdown
Member

Fast-track? Please 👍🏻
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jul 21, 2020
@addaleax

addaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member Author

Landed in feb93c4
lin7sh reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Jul 21, 2020
addaleax added a commit that referenced this pull request Jul 21, 2020
@addaleax
src: guard against nullptr deref in TimerWrapHandle::Stop
feb93c4 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@addaleax
addaleax deleted the timer-wrap-nullptr-deref branch July 21, 2020 19:11
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@addaleax @cjihrig
src: guard against nullptr deref in TimerWrapHandle::Stop
fe69e1e 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@ruyadorno ruyadorno added the backport-requested-v14.x label Jul 28, 2020
@ruyadorno

ruyadorno commented Jul 28, 2020

Copy link
Copy Markdown
Member

This does not land cleanly on v14.x 🤔 should it be backported ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
@addaleax @targos
src: guard against nullptr deref in TimerWrapHandle::Stop
b1d5160 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
This was referenced May 22, 2023
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 Rednickle/node-1#72
Open
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 molllyn1/node#78
Open
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 aliceUnhinged613/node#92
Open
@137717unity 137717unity mentioned this pull request May 22, 2023
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 137717unity/node#95
Open
@snyk-bot snyk-bot mentioned this pull request May 23, 2023
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 ron-a20/node#95
Open
@wedataintelligence wedataintelligence mentioned this pull request May 24, 2023
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 wedataintelligence/node#77
Open
@baby636 baby636 mentioned this pull request May 24, 2023
[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 3.15.0 baby636/node#92
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
[Snyk] Fix for 28 vulnerabilities aliceUnhinged613/node#98
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
[Snyk] Fix for 28 vulnerabilities wedataintelligence/node#87
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
[Snyk] Fix for 37 vulnerabilities baby636/node#110
Open
@ron-a20 ron-a20 mentioned this pull request Dec 19, 2023
[Snyk] Fix for 30 vulnerabilities ron-a20/node#112
Open
@137717unity 137717unity mentioned this pull request Dec 19, 2023
[Snyk] Fix for 30 vulnerabilities 137717unity/node#113
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 19, 2023
[Snyk] Fix for 30 vulnerabilities wedataintelligence/node#96
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 19, 2023
[Snyk] Fix for 30 vulnerabilities aliceUnhinged613/node#114
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
[Snyk] Fix for 43 vulnerabilities baby636/node#126
Open
@137717unity 137717unity mentioned this pull request Apr 14, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 137717unity/node#125
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 14, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 aliceUnhinged613/node#125
Open
@ron-a20 ron-a20 mentioned this pull request Apr 14, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 ron-a20/node#123
Open
@molllyn1 molllyn1 mentioned this pull request Apr 14, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 molllyn1/node#109
Open
@kissofire kissofire mentioned this pull request Apr 14, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.2.13 to 3.15.0 kissofire/node#126
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 14, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 wedataintelligence/node#108
Open
@baby636 baby636 mentioned this pull request Apr 15, 2024
[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 3.15.0 baby636/node#146
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@addaleax @nodejs-github-bot @jasnell @ruyadorno @gengjiawen @devnexen @richardlau @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.