GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: run test-benchmark-napi on arm by Trott · Pull Request #34502 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jul 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Necessary Makefile changes have happened. This now passes in CI.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jul 24, 2020
@Trott
Trott marked this pull request as draft July 24, 2020 04:22
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Trott marked this pull request as ready for review July 24, 2020 04:42
@Trott
Trott force-pushed the run-it branch from 010f1d3 to eb37289 Compare July 24, 2020 04:45
richardlau
richardlau approved these changes Jul 24, 2020
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 24, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2020 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32503/ ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rickyes
rickyes approved these changes Jul 25, 2020
View reviewed changes
trivikr
trivikr approved these changes Jul 26, 2020
View reviewed changes
@Trott

Trott commented Jul 26, 2020

Copy link
Copy Markdown
Member Author

Landed in 31ba9a2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit that referenced this pull request Jul 26, 2020
@Trott
test: run test-benchmark-napi on arm
31ba9a2 
Necessary Makefile changes have happened. This now passes in CI.

PR-URL: #34502
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott closed this Jul 26, 2020
@Trott
Trott force-pushed the run-it branch from eb37289 to 31ba9a2 Compare July 26, 2020 05:05
@Trott
Trott deleted the run-it branch July 26, 2020 05:05
@ruyadorno

ruyadorno commented Jul 28, 2020

Copy link
Copy Markdown
Member

This doesn't land cleanly on v14.x, should it be backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added the backport-requested-v14.x label Jul 28, 2020
@Trott

Trott commented Aug 1, 2020

Copy link
Copy Markdown
Member Author

This doesn't land cleanly on v14.x, should it be backported?

As of this writing, it cherry-picks cleanly to v14.x-staging (which is at d910672). No backport needed anymore?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: run test-benchmark-napi on arm
00b9d95 
Necessary Makefile changes have happened. This now passes in CI.

PR-URL: #34502
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@rickyes rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @nodejs-github-bot @ruyadorno @richardlau @trivikr @rickyes @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.