GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — async_hooks: improve property descriptors in als.bind by Flarna · Pull Request #34620 · nodejs/node

Conversation

@Flarna

@Flarna Flarna commented Aug 4, 2020

Copy link
Copy Markdown
Member

The length property should be non enumerable to match behavior of normal functions.

The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: #30932 (comment)

Both properties should be configurable.

Refs: #34574

fyi @jasnell

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
puzpuzpuz, bricss, and Qard reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@Flarna
[async_hooks] improve property descriptors in als.bind
ccc0467 
The length property should be non enumerable to match behavior of
normal functions.

The asyncResource property is enumerable and therefore it should be
also writable to avoid issues like there:
nodejs#30932 (comment)

Both properties should be configurable.

Refs: nodejs#34574
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4202
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the async_hooks Issues and PRs related to the async hooks subsystem. label Aug 4, 2020
@Flarna Flarna mentioned this pull request Aug 4, 2020
async_hooks: add AsyncResource.bind utility #34574
Closed
4 tasks done
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32622/
Flarna reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
puzpuzpuz
puzpuzpuz approved these changes Aug 4, 2020
View reviewed changes
@Flarna Flarna added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 4, 2020
addaleax
addaleax approved these changes Aug 4, 2020
View reviewed changes
jasnell
jasnell approved these changes Aug 4, 2020
View reviewed changes
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 4, 2020
@jasnell

jasnell commented Aug 4, 2020

Copy link
Copy Markdown
Member

fast-track? please 👍🏻
puzpuzpuz, Flarna, and Qard reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Flarna added a commit that referenced this pull request Aug 4, 2020
@Flarna
async_hooks: improve property descriptors in als.bind
3ea94ec 
The length property should be non enumerable to match behavior of
normal functions.

The asyncResource property is enumerable and therefore it should be
also writable to avoid issues like there:
#30932 (comment)

Both properties should be configurable.

Refs: #34574

PR-URL: #34620
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Flarna

Flarna commented Aug 4, 2020

Copy link
Copy Markdown
Member Author

Landed in 3ea94ec
jasnell and Qard reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna Flarna closed this Aug 4, 2020
@Flarna Flarna changed the title [async_hooks] improve property descriptors in als.bind async_hooks: improve property descriptors in als.bind Aug 4, 2020
@Flarna
Flarna deleted the als-bind-props branch August 4, 2020 16:06
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@Flarna @addaleax
async_hooks: improve property descriptors in als.bind
0af9bee 
The length property should be non enumerable to match behavior of
normal functions.

The asyncResource property is enumerable and therefore it should be
also writable to avoid issues like there:
#30932 (comment)

Both properties should be configurable.

Refs: #34574

PR-URL: #34620
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Aug 10, 2020
v14.8.0 proposal #34704
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@Flarna @codebytere
async_hooks: improve property descriptors in als.bind
0730c76 
The length property should be non enumerable to match behavior of
normal functions.

The asyncResource property is enumerable and therefore it should be
also writable to avoid issues like there:
#30932 (comment)

Both properties should be configurable.

Refs: #34574

PR-URL: #34620
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Flarna @addaleax
async_hooks: improve property descriptors in als.bind
07968ac 
The length property should be non enumerable to match behavior of
normal functions.

The asyncResource property is enumerable and therefore it should be
also writable to avoid issues like there:
#30932 (comment)

Both properties should be configurable.

Refs: #34574

PR-URL: #34620
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
v12.19.0 proposal #35401
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
+1 more reviewer
@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Flarna @nodejs-github-bot @jasnell @addaleax @puzpuzpuz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.