GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — process: improve rejections tracking performance by mmarchini · Pull Request #34862 · nodejs/node

Conversation

@mmarchini

@mmarchini mmarchini commented Aug 21, 2020

Copy link
Copy Markdown
Contributor

Fixes: #34851

Before landing
  • Explain why this works on commit message
  • Add comments to the code to explain what's going on
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@mmarchini
process: improve rejections tracking performance
a8609b9 
TODO: explain on commit message why this improves performance.

Fixes: nodejs#34851
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Aug 21, 2020
@mmarchini mmarchini added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 21, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 21, 2020
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32877/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmarchini
fixup! process: improve rejections tracking performance
25c01c6
@mmarchini mmarchini mentioned this pull request Aug 21, 2020
post-build-status-update (maybe all pipeline jobs?) is broken nodejs/build#2413
Closed
@mmarchini

mmarchini commented Aug 21, 2020

Copy link
Copy Markdown
Contributor Author

Test failures look legit, but I can't reproduce locally
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 22, 2020
CI Reliability 2020-08-22 nodejs/reliability#51
Open
CI Reliability 2020-08-23 nodejs/reliability#52
Open
CI Reliability 2020-08-24 nodejs/reliability#53
Open
CI Reliability 2020-08-25 nodejs/reliability#54
Open
CI Reliability 2020-08-26 nodejs/reliability#55
Open
CI Reliability 2020-08-27 nodejs/reliability#56
Open
@matt4530

matt4530 commented Sep 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Just following up on this since it looks like the CI process got fixed (or at least it is no longer reporting). Can we re-run the CI to see if your patch passes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford
guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@Uzlopak Uzlopak mentioned this pull request Mar 17, 2024
fix: improve event-loop promise state tracking #52108
Merged
@Uzlopak

Uzlopak commented May 6, 2024

Copy link
Copy Markdown
Contributor

@H4ad

We can close this PR now ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmarchini mmarchini closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Promise Rejections delay process exiting (and others) in processPromiseRejections

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mmarchini @nodejs-github-bot @matt4530 @Uzlopak
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.