GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — fix: improve event-loop promise state tracking by Uzlopak · Pull Request #52108 · nodejs/node Conversation
|
|
I think we should remove |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, the added test is flaky: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
13e0e13 to
014d1b5
Compare
|
It should be now less flaky. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Are the test failures related to my patch? I have no osx-arm machine to check it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
71b3502 to
691b724
Compare
|
@Uzlopak they do not seem to be related |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
691b724 to
a5dc9a3
Compare
|
@BridgeAR |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
a5dc9a3 to
6fd930b
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Still lgtm
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Whoa!!!! the CI is green. the CI is green! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in be8d64e |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #52108 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #52108 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#52108 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Problem with GC (million promise rejections) Promise Rejections delay process exiting (and others) in processPromiseRejections
There was an error while loading. Please reload this page.