GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add Windows-specific info to `subprocess.kill` by joaolucasl · Pull Request #34867 · nodejs/node

Conversation

@joaolucasl

@joaolucasl joaolucasl commented Aug 21, 2020

Copy link
Copy Markdown
Contributor

Clarify the inner workings of subprocess.kill() on Windows,since termination signals are not available there.

I used the the LibUV docs to make sure that this was the actual behaviour, after noticing the code on internal/child_process would ultimately call it via process_wrap.

Fixes: #34858

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to Node.js documentation. labels Aug 21, 2020
@joaolucasl joaolucasl mentioned this pull request Aug 21, 2020
doc: child_process.kill() on windows needs clarification #34858
Closed
1 task
juanarbol
juanarbol approved these changes Aug 21, 2020
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Not a blocker: I'd put this just after the Linux specification and before code example.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@s4m0r4m4

s4m0r4m4 commented Aug 22, 2020

Copy link
Copy Markdown

Looks good to me, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Aug 22, 2020

Copy link
Copy Markdown
Member

@nodejs/child_process
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaolucasl
joaolucasl force-pushed the docs/windows-child-process-kill branch from 8d40f81 to 28587cd Compare August 22, 2020 16:37
jasnell
jasnell approved these changes Aug 24, 2020
View reviewed changes
@s4m0r4m4

s4m0r4m4 commented Sep 9, 2020

Copy link
Copy Markdown

Who do we need to give the OK and merge this in? I see @jasnell approved it, not sure if he can merge it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zenflow
zenflow reviewed Sep 12, 2020
View reviewed changes
Comment thread doc/api/child_process.md Outdated

@zenflow zenflow Sep 12, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say SIGINT and SIGTERM instead?
If I'm not mistaken, SIGINT isn't available here either.
And SIGKILL, if available, forcibly terminates (so it's unavailability doesn't help explain why child process must be forcefully terminated.. SIGKILL wouldn't be useful for avoiding forceful termination anyways).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bcoe bcoe mentioned this pull request Sep 13, 2020
fs: remove experimental language from rmdir recursive #35171
Closed
4 tasks done
@aduh95

aduh95 commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

@joaolucasl This needs a rebase, and there is one comment left that needs to be addressed before landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. label Nov 8, 2020
@github-actions

github-actions Bot commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaolucasl

joaolucasl commented Nov 9, 2020

Copy link
Copy Markdown
Contributor Author

Will update it this week.
s4m0r4m4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Nov 11, 2020
View reviewed changes
Comment thread doc/api/child_process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Nov 11, 2020
View reviewed changes
Comment thread doc/api/child_process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@PoojaDurgad

PoojaDurgad commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

@joaolucasl - looks like this PR have gotten a little stuck. need a rebase to resolve git conflicts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the docs/windows-child-process-kill branch from 7160bc5 to c0ba12a Compare January 8, 2021 03:07
@Trott

Trott commented Jan 8, 2021

Copy link
Copy Markdown
Member

I rebased, fixed the merge conflict, fixed the lint error, squashed, and force pushed.
s4m0r4m4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zenflow
zenflow reviewed Mar 25, 2021
View reviewed changes
Comment thread doc/api/child_process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joaolucasl
joaolucasl force-pushed the docs/windows-child-process-kill branch from c0ba12a to 57f3583 Compare March 26, 2021 16:55
@joaolucasl

joaolucasl commented Mar 26, 2021

Copy link
Copy Markdown
Contributor Author

Sorry for the huge delay in updating this. Thanks @zenflow for the suggestion.

Ready for review!
zenflow reacted with thumbs up emoji zenflow reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. review wanted PRs that need review. labels Mar 26, 2021
@guybedford
guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33
Trott
Trott approved these changes Mar 30, 2021
View reviewed changes
@joaolucasl @Trott
doc: add Windows-specific info to subprocess.kill()
504ed7c 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: nodejs#34858

PR-URL: nodejs#34867
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Trott force-pushed the docs/windows-child-process-kill branch from 57f3583 to 504ed7c Compare March 30, 2021 11:08
@Trott

Trott commented Mar 30, 2021

Copy link
Copy Markdown
Member

Landed in 504ed7c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 504ed7c into nodejs:master Mar 30, 2021
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@joaolucasl @MylesBorins
doc: add Windows-specific info to subprocess.kill()
13c3924 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: #34858

PR-URL: #34867
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
v15.14.0 proposal #38084
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@joaolucasl @targos
doc: add Windows-specific info to subprocess.kill()
35a382e 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: #34858

PR-URL: #34867
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@joaolucasl
joaolucasl deleted the docs/windows-child-process-kill branch June 11, 2021 12:56
@sindresorhus sindresorhus mentioned this pull request Jul 10, 2026
subprocess.kill('SIGWINCH') forcefully terminates subprocesses on Windows #64324
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@zenflow zenflow zenflow left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to Node.js documentation. review wanted PRs that need review. stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: child_process.kill() on windows needs clarification

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@joaolucasl @s4m0r4m4 @targos @aduh95 @PoojaDurgad @Trott @jasnell @zenflow @juanarbol @DerekNonGeneric @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.