GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(35353) Added feature updateSettings for http2 SecureServer and Server by grayparser · Pull Request #35383 · nodejs/node

Conversation

@grayparser

@grayparser grayparser commented Sep 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #35353

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji szmarczak reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
@grayparser
grayparser requested review from a team as code owners September 28, 2020 00:53
@nodejs-github-bot nodejs-github-bot added the http2 Issues and PRs related to the http2 subsystem. label Sep 28, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@grayparser

grayparser commented Sep 28, 2020

Copy link
Copy Markdown
Author

This is not done yet, I need to add tests until it is complete
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the wip Issues and PRs that are still a work in progress. label Sep 28, 2020
@grayparser
grayparser force-pushed the 35353 branch from ad16394 to 5e4613e Compare September 28, 2020 15:50
@grayparser

grayparser commented Sep 28, 2020

Copy link
Copy Markdown
Author

@mscdex This is ready for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Sep 28, 2020
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@grayparser
grayparser force-pushed the 35353 branch from 5e4613e to a30afb5 Compare September 28, 2020 16:07
@grayparser grayparser mentioned this pull request Sep 28, 2020
Added updateSettings() for node/http2 DefinitelyTyped/DefinitelyTyped#48277
Closed
10 tasks done
@Flarna Flarna removed the wip Issues and PRs that are still a work in progress. label Sep 28, 2020
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Comment thread doc/api/errors.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Comment thread doc/api/http2.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Comment thread doc/api/http2.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Comment thread doc/api/http2.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Comment thread tools/lint-md.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Comment thread test/internet/test-http2-update-settings.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 30, 2020
@Trott

Trott commented Sep 30, 2020

Copy link
Copy Markdown
Member

Welcome, @Vboivin, and thanks for the pull request!
grayparser reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lundibundi
lundibundi reviewed Sep 30, 2020
View reviewed changes
Comment thread lib/internal/http2/core.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/http2/core.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@grayparser
grayparser requested review from Trott and lundibundi and removed request for a team October 1, 2020 06:45
@grayparser

grayparser commented Oct 1, 2020

Copy link
Copy Markdown
Author

@lundibundi @Trott I did the suggested changes, the PR is ready for review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lundibundi
lundibundi approved these changes Oct 1, 2020
View reviewed changes

@lundibundi lundibundi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work and thanks for the contribution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
grayparser reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread test/parallel/test-http2-update-settings.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/http2.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 1, 2020
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33317/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 23, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Conflicts showed up with the rebasing for the commit queue, so I pulled this down locally, rebased manually, added a fixup for some punctuation nits, and force-pushed. Let's run CI again and if that works out OK, this should be good to land.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 23, 2020
Trott
Trott approved these changes Oct 23, 2020
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2020 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33842/ ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rickyes
rickyes approved these changes Oct 25, 2020
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 25, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 25, 2020
@github-actions

github-actions Bot commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

Landed in 1d5b91d...629e1ab
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Oct 25, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 25, 2020
Vincent Boivin @nodejs-github-bot
http2: add updateSettings to both http2 servers
629e1ab 
Allow the user to update the server settings
after using http2.createSecureServer() or
after using http2.createServer().

Fixes: #35353

PR-URL: #35383
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@Trott

Trott commented Oct 25, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉
szmarczak and grayparser reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 3, 2020
Vincent Boivin @targos
http2: add updateSettings to both http2 servers
883ed4b 
Allow the user to update the server settings
after using http2.createSecureServer() or
after using http2.createServer().

Fixes: #35353

PR-URL: #35383
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
targos added a commit that referenced this pull request Nov 3, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
05fdcdf 
Notable changes:

child_process:
  * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369
dns:
  * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824
http:
  * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895
http2:
  * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383
lib:
  * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895
src:
  * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010
v8:
  * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807
  * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807
worker:
  * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664

PR-URL: TODO
@targos targos mentioned this pull request Nov 3, 2020
v15.1.0 release proposal #35948
Merged
targos added a commit that referenced this pull request Nov 3, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
0dd5d63 
Notable changes:

child_process:
  * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369
dns:
  * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824
http:
  * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895
http2:
  * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383
lib:
  * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895
src:
  * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010
v8:
  * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807
  * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807
worker:
  * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664

PR-URL: #35948
MylesBorins pushed a commit that referenced this pull request Nov 4, 2020
@targos @MylesBorins
2020-11-04, Version 15.1.0 (Current)
a90fdc1 
Notable changes:

child_process:
  * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369
dns:
  * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824
http:
  * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895
http2:
  * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383
lib:
  * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895
src:
  * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010
v8:
  * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807
  * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807
worker:
  * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664

PR-URL: #35948
targos added a commit that referenced this pull request Nov 4, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
2291e07 
Notable changes:

child_process:
  * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369
dns:
  * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824
http:
  * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895
http2:
  * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383
lib:
  * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895
src:
  * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010
v8:
  * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807
  * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807
worker:
  * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664

PR-URL: #35948
targos added a commit that referenced this pull request Nov 4, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
8caa6a9 
Notable changes:

child_process:
  * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369
dns:
  * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824
http:
  * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895
http2:
  * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383
lib:
  * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895
src:
  * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010
v8:
  * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807
  * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807
worker:
  * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664

PR-URL: #35948
targos pushed a commit that referenced this pull request May 1, 2021
Vincent Boivin @targos
http2: add updateSettings to both http2 servers
2e25922 
Allow the user to update the server settings
after using http2.createSecureServer() or
after using http2.createServer().

Fixes: #35353

PR-URL: #35383
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes
+3 more reviewers
@lundibundi lundibundi lundibundi approved these changes
@apapirovski apapirovski apapirovski approved these changes
@rickyes rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. http2 Issues and PRs related to the http2 subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update HTTP/2 server settings after .listen()

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@grayparser @nodejs-github-bot @Trott @ZYSzys @apapirovski @mcollina @jasnell @lundibundi @rickyes @mscdex @aduh95 @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.