GeezerVison

- Loading data for nodejs/node/pull/35520
✔  Done loading data for nodejs/node/pull/35520
----------------------------------- PR info ------------------------------------
Title      Don't 'exit' a script meant to be "source"d (#35520)
Author     François-Denis Gonthier  (@fdgonthier, first-time contributor)
Branch     fdgonthier:issue-35519 -> nodejs:master
Labels     android, build
Commits    1
 - Don't 'exit' a script meant to be "source"d
Committers 1
 - Myles Borins 
PR-URL: https://github.com/nodejs/node/pull/35520
Fixes: https://github.com/nodejs/node/issues/35519
Reviewed-By: Michaël Zasso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35520
Fixes: https://github.com/nodejs/node/issues/35519
Reviewed-By: Michaël Zasso 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-12-27T13:43:24Z: https://ci.nodejs.org/job/node-test-pull-request/35092/
- Querying data for job/node-test-pull-request/35092/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Tue, 06 Oct 2020 15:32:18 GMT
   ✔  Approvals: 1
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/35520#pullrequestreview-558928296
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 35520
From https://github.com/nodejs/node
 * branch                  refs/pull/35520/merge -> FETCH_HEAD
✔  Fetched commits as acaa58e60260..fb7894a45d1f
--------------------------------------------------------------------------------
Auto-merging android-configure
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 1469 and retry the command.
[master 137faf9812] Don't 'exit' a script meant to be "source"d
 Author: François-Denis Gonthier 
 Date: Tue Oct 6 11:29:25 2020 -0400
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
Don't 'exit' a script meant to be "source"d
Running exit in a script meant to be sourced means the user shell will

exit, which prevents seeing the error message, and is generally very

annoying.
PR-URL: #35520

Fixes: #35519

Reviewed-By: Michaël Zasso [email protected]
[master cb48481419] Don't 'exit' a script meant to be "source"d

Author: François-Denis Gonthier [email protected]

Date: Tue Oct 6 11:29:25 2020 -0400

1 file changed, 3 insertions(+), 3 deletions(-)

✖  cb4848141966adb8ba66394ebc8fdd2aaa99c6fe

✔  6:7      Valid fixes URL.                          fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  5:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Missing subsystem.                        subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.