GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v10.23.0 proposal by richardlau · Pull Request #35544 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Oct 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

2020-10-27, Version 10.23.0 'Dubnium' (LTS), @richardlau

Notable changes

  • deps:
    • upgrade npm to 6.14.8 (Ruy Adorno) #34834
  • n-api:
    • create N-API version 7 (Gabriel Schulhof) #35199
    • expose napi_build_version variable (NickNaso) #27835
  • tools:
    • add debug entitlements for macOS 10.15+ (Gabriele Greco) #34378

Commits

  • [b83f9a56fc] - build: expose napi_build_version variable (NickNaso) #27835
  • [020ba1a2b8] - build: enable backtrace when V8 is built for PPC and S390x (Michaël Zasso) #32113
  • [eee9412a8c] - deps: upgrade npm to 6.14.8 (Ruy Adorno) #34834
  • [038593d5ff] - deps: upgrade npm to 6.14.7 (claudiahdz) #34468
  • [3564424625] - deps: V8: cherry-pick eec10a2fd8fa (Stephen Belanger) #33778
  • [e9e86e1b60] - http2: support non-empty DATA frame with END_STREAM flag (Carlos Lopez) #33875
  • [751820b6c2] - http2,doc: minor fixes (Alba Mendez) #28044
  • [54c2bc2e62] - (SEMVER-MINOR) n-api: create N-API version 7 (Gabriel Schulhof) #35199
  • [2eb627301c] - src: allows escaping NODE_OPTIONS with backslashes (Maël Nison) #24065
  • [5170d14b36] - test: fix test-linux-perf flakiness (Matheus Marchini) #27615
  • [21b86d7f19] - test,v8: skip less and stabilize test-linux-perf.js (Refael Ackermann) #27364
  • [ee11ab50a7] - tools: add debug entitlements for macOS 10.15+ (Gabriele Greco) #34378

cc @nodejs/releasers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
targos and others added 10 commits October 5, 2020 10:56
@targos @richardlau
build: enable backtrace when V8 is built for PPC and S390x
020ba1a
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Qard @richardlau
deps: V8: cherry-pick eec10a2fd8fa
3564424
Original commit message:

    [promisehook] Add before/after hooks to thenable tasks

    This will allow Node.js to properly track async context in thenables.

    Change-Id: If441423789a78307a57ad7e645daabf551cddb57
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624
    Reviewed-by: Camillo Bruni <[email protected]>
    Reviewed-by: Sathya Gunasekaran  <[email protected]>
    Commit-Queue: Gus Caplan <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#68207}

Refs: v8/v8@eec10a2

PR-URL: #33778
Backport-PR-URL: #35393
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Maël Nison @richardlau
src: allows escaping NODE_OPTIONS with backslashes
2eb6273
The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with `--require` (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

Fixes: #12971

PR-URL: #24065
Backport-PR-URL: #35342
Reviewed-By: Anna Henningsen <[email protected]>

Refs: microsoft/vscode-js-debug#769
@NickNaso @richardlau
build: expose napi_build_version variable
b83f9a5
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Backport-PR-URL: #35266
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Gabriel Schulhof @richardlau
n-api: create N-API version 7
54c2bc2
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.

Signed-off-by: Gabriel Schulhof <[email protected]>
PR-URL: #35199
Backport-PR-URL: #35336
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mildsunrise @richardlau
http2,doc: minor fixes
751820b
Some small fixes on HTTP/2 and its documentation:

 - Add a note that, on server streams, it's not necessary
   to start data flow.

 - Set EOF flag if we have marked all data for sending:
   there's no need to wait until the queue is
   actually empty (and send a separate, empty DATA).

   (Note that, even with this change, a separate DATA
   frame will always be sent, because the streams
   layer waits until data has been flushed before
   dispatching EOF)

PR-URL: #28044
Backport-PR-URL: #34857
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@clshortfuse @richardlau
http2: support non-empty DATA frame with END_STREAM flag
e9e86e1
Adds support for reading from a stream where the final frame is a
non-empty DATA frame with the END_STREAM flag set, instead of hanging
waiting for another frame.

Fixes: #31309
Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback

PR-URL: #33875
Backport-PR-URL: #34857
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ggreco @richardlau
tools: add debug entitlements for macOS 10.15+
ee11ab5
To debug native modules node should be a debuggable process, that will
require the **com.apple.security.get-task-allow** entitlement to be
added to the codesign procedure.

PR-URL: #34378
Fixes: #34340
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@claudiahdz @richardlau
deps: upgrade npm to 6.14.7
038593d
PR-URL: #34468
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@ruyadorno @richardlau
deps: upgrade npm to 6.14.8
eee9412
PR-URL: #34834
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v10.x labels Oct 7, 2020
@richardlau
richardlau force-pushed the v10.23.0-proposal branch from ee3a54c to 838777c Compare October 7, 2020 16:12
richardlau added a commit that referenced this pull request Oct 7, 2020
@richardlau
2020-10-27, Version 10.23.0 'Dubnium' (LTS)
838777c
Notable changes:
- deps:
  - upgrade npm to 6.14.8 (Ruy Adorno)
    #34834
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
    #35199
  - expose napi_build_version variable (NickNaso)
    #27835
- tools:
  - add debug entitlements for macOS 10.15+ (Gabriele Greco)
    #34378

PR-URL: #35544
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 7, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 7, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33460/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3450/
CITGM: https://ci.nodejs.org/job/citgm-smoker/2507/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

crypt096
crypt096 approved these changes Oct 8, 2020
View reviewed changes
mmarchini and others added 3 commits October 9, 2020 12:54
@mmarchini @richardlau
test: fix test-linux-perf flakiness
5170d14
The new V8 seems to be optimizing the functions we use in this test
faster than before. Increasing the sampling frequency for Linux perf
fixes the issue.

PR-URL: #27615
Refs: v8/v8@7.4.288.21...7.4.288.27
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@refack @richardlau
test,v8: skip less and stabilize test-linux-perf.js
21b86d7
Co-authored-by: Matheus Marchini <[email protected]>

PR-URL: #27364
Refs: nodejs/build#1774
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@richardlau
2020-10-27, Version 10.23.0 'Dubnium' (LTS)
351c02d
Notable changes:
- deps:
  - upgrade npm to 6.14.8 (Ruy Adorno)
    #34834
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
    #35199
  - expose napi_build_version variable (NickNaso)
    #27835
- tools:
  - add debug entitlements for macOS 10.15+ (Gabriele Greco)
    #34378

PR-URL: #35544
@richardlau
richardlau force-pushed the v10.23.0-proposal branch from 838777c to 351c02d Compare October 9, 2020 18:31
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 9, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33503/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau mentioned this pull request Oct 9, 2020
doc: refactor the n-api matrix #35345
Closed
3 tasks done
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33506/ ✔️
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3458/ ✔️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rickyes rickyes mentioned this pull request Oct 10, 2020
inject NODE_OPTIONS will cause Node 10.x crash when fork child process microsoft/vscode-js-debug#769
Closed
@richardlau

richardlau commented Oct 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Rc.0 build: https://ci-release.nodejs.org/job/iojs+release/6385/
Rc.0 downloads: https://nodejs.org/download/rc/v10.23.0-rc.0/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codebytere
codebytere approved these changes Oct 13, 2020
View reviewed changes
@richardlau

richardlau commented Oct 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Release build: https://ci-release.nodejs.org/job/iojs+release/6424/
Rebuild of vs2017-x64 (which failed with a connection reset): https://ci-release.nodejs.org/job/iojs+release/6428/nodes=vs2017-x64/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs
BethGriggs approved these changes Oct 27, 2020
View reviewed changes
@richardlau
richardlau merged commit 351c02d into v10.x Oct 27, 2020
richardlau added a commit that referenced this pull request Oct 27, 2020
@richardlau
Working on v10.23.1
89d664d
PR-URL: #35544
richardlau added a commit that referenced this pull request Oct 27, 2020
@richardlau
2020-10-27, Version 10.23.0 'Dubnium' (LTS)
62ead4e
Notable changes:
- deps:
  - upgrade npm to 6.14.8 (Ruy Adorno)
    #34834
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
    #35199
  - expose napi_build_version variable (NickNaso)
    #27835
- tools:
  - add debug entitlements for macOS 10.15+ (Gabriele Greco)
    #34378

PR-URL: #35544
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Oct 27, 2020
@richardlau
Blog: v10.23.0 release post
046eaa7
Refs: nodejs/node#35544
@richardlau richardlau mentioned this pull request Oct 27, 2020
Blog: v10.23.0 release post nodejs/nodejs.org#3480
Merged
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Oct 27, 2020
@richardlau
Blog: v10.23.0 release post (#3480)
6da2454
Refs: nodejs/node#35544
@richardlau
richardlau deleted the v10.23.0-proposal branch October 29, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
+1 more reviewer
@crypt096 crypt096 crypt096 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

15 participants

@richardlau @nodejs-github-bot @codebytere @BethGriggs @crypt096 @targos @Qard @NickNaso @mildsunrise @clshortfuse @ggreco @claudiahdz @ruyadorno @mmarchini @refack
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.