GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — report: honor setUncaughtExceptionCaptureCallback by gireeshpunathil · Pull Request #35595 · nodejs/node

Conversation

@gireeshpunathil

@gireeshpunathil gireeshpunathil commented Oct 11, 2020

Copy link
Copy Markdown
Member

This api does not alter the behavior of diagnostic
report configured to on uncaught exceptions.
This is deemed as a bug. Honor this API.

Refs: #35588

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @addaleax

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Oct 11, 2020
addaleax
addaleax approved these changes Oct 11, 2020
View reviewed changes
cjihrig
cjihrig reviewed Oct 11, 2020
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
cjihrig
cjihrig approved these changes Oct 11, 2020
View reviewed changes
Comment thread test/report/test-report-uncaught-exception-override.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/report/test-report-uncaught-exception-override.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Oct 12, 2020
View reviewed changes
richardlau
richardlau approved these changes Oct 12, 2020
View reviewed changes
jasnell
jasnell approved these changes Oct 13, 2020
View reviewed changes
@gireeshpunathil gireeshpunathil added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Oct 13, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33560/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 15, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 15, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33637/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil
lib: honor setUncaughtExceptionCaptureCallback
ddff2b2 
This api does not alter the behavior of diagnostic
report configured on uncaught exceptions.
This is deemed as a bug. Honor this API.

Refs: nodejs#35588
PR-URL: nodejs#35595
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@gireeshpunathil
gireeshpunathil force-pushed the report-off-on-custom-exception-hook branch from 7ea364a to ddff2b2 Compare October 15, 2020 07:25
@gireeshpunathil
gireeshpunathil merged commit ddff2b2 into nodejs:master Oct 15, 2020
@gireeshpunathil

gireeshpunathil commented Oct 15, 2020

Copy link
Copy Markdown
Member Author

landed in ddff2b2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Nov 24, 2020
@gireeshpunathil @MylesBorins
lib: honor setUncaughtExceptionCaptureCallback
d58a466 
This api does not alter the behavior of diagnostic
report configured on uncaught exceptions.
This is deemed as a bug. Honor this API.

Refs: #35588
PR-URL: #35595
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@gireeshpunathil @joesepi
lib: honor setUncaughtExceptionCaptureCallback
8716650 
This api does not alter the behavior of diagnostic
report configured on uncaught exceptions.
This is deemed as a bug. Honor this API.

Refs: nodejs#35588
PR-URL: nodejs#35595
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@gireeshpunathil @nodejs-github-bot @jasnell @addaleax @cjihrig @joyeecheung @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.