GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use kbd element in os doc by Trott · Pull Request #35656 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 15, 2020

Copy link
Copy Markdown
Member

Use kbd element for key strokes and remove extra parentheses.

Before:

image

After:

Screen Shot 2020-10-15 at 3 52 00 AM

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. os Issues and PRs related to the os subsystem. labels Oct 15, 2020
lpinca
lpinca approved these changes Oct 15, 2020
View reviewed changes
evanlucas
evanlucas approved these changes Oct 19, 2020
View reviewed changes
@Trott
doc: use kbd element in os doc
3d9310d 
Use kbd element for key strokes and remove extra parentheses.

PR-URL: nodejs#35656
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@Trott
Trott force-pushed the os-kbd branch from c7336cf to 3d9310d Compare October 20, 2020 11:46
@Trott

Trott commented Oct 20, 2020

Copy link
Copy Markdown
Member Author

Landed in 3d9310d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 3d9310d into nodejs:master Oct 20, 2020
@Trott
Trott deleted the os-kbd branch October 20, 2020 11:46
BethGriggs pushed a commit that referenced this pull request Oct 21, 2020
@Trott @BethGriggs
doc: use kbd element in os doc
6e91d64 
Use kbd element for key strokes and remove extra parentheses.

PR-URL: #35656
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2020
v15.0.1 proposal #35736
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@Trott @BethGriggs
doc: use kbd element in os doc
d8e9fa3 
Use kbd element for key strokes and remove extra parentheses.

PR-URL: #35656
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
doc: use kbd element in os doc
492f88c 
Use kbd element for key strokes and remove extra parentheses.

PR-URL: #35656
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
doc: use kbd element in os doc
df4043b 
Use kbd element for key strokes and remove extra parentheses.

PR-URL: #35656
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+1 more reviewer
@evanlucas evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @evanlucas @lpinca @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.