GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update ESLint to 7.12.1 by cjihrig · Pull Request #35799 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Oct 25, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Update ESLint to 7.12.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 25, 2020
Trott
Trott approved these changes Oct 25, 2020
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
juanarbol
juanarbol approved these changes Oct 26, 2020
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
watilde
watilde approved these changes Oct 26, 2020
View reviewed changes
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33859/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
cjihrig force-pushed the eslint branch from 5d9ee63 to 1b1fda7 Compare October 27, 2020 03:49
@cjihrig cjihrig changed the title tools: update ESLint to 7.12.0 tools: update ESLint to 7.12.1 Oct 27, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2020 •
edited by cjihrig
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34003/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 31, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 31, 2020
@github-actions

github-actions Bot commented Oct 31, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/35799
✔  Done loading data for nodejs/node/pull/35799
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.12.1 (#35799)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     tools
Commits    2
 - tools: update ESLint to 7.12.0
 - tools: update ESLint to 7.12.1
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/35799
Reviewed-By: Rich Trott 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Daijiro Wachi 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35799
Reviewed-By: Rich Trott 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Daijiro Wachi 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: update ESLint to 7.12.0
   ⚠  - tools: update ESLint to 7.12.1
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-10-31T21:09:33Z: https://ci.nodejs.org/job/node-test-pull-request/34003/
- Querying data for job/node-test-pull-request/34003/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Sun, 25 Oct 2020 14:49:54 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35799#pullrequestreview-516395615
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/35799#pullrequestreview-516416391
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35799#pullrequestreview-516417296
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/339529805
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 31, 2020
cjihrig added 2 commits October 31, 2020 17:50
@cjihrig
tools: update ESLint to 7.12.0
868d81e 
Update ESLint to 7.12.0

PR-URL: nodejs#35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@cjihrig
tools: update ESLint to 7.12.1
7ebae13 
Update ESLint to 7.12.1

PR-URL: nodejs#35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@cjihrig
cjihrig force-pushed the eslint branch from 1b1fda7 to 7ebae13 Compare October 31, 2020 21:50
@cjihrig
cjihrig merged commit 7ebae13 into nodejs:master Oct 31, 2020
@cjihrig
cjihrig deleted the eslint branch October 31, 2020 21:51
targos pushed a commit that referenced this pull request Nov 3, 2020
@cjihrig @targos
tools: update ESLint to 7.12.0
d20b318 
Update ESLint to 7.12.0

PR-URL: #35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request Nov 3, 2020
@cjihrig @targos
tools: update ESLint to 7.12.1
a07d1af 
Update ESLint to 7.12.1

PR-URL: #35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
v15.1.0 release proposal #35948
Merged
@targos targos added the dont-land-on-v14.x label Apr 30, 2021
@targos targos removed the dont-land-on-v14.x label May 16, 2021
targos pushed a commit that referenced this pull request May 16, 2021
@cjihrig @targos
tools: update ESLint to 7.12.0
8b2df0c 
Update ESLint to 7.12.0

PR-URL: #35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request May 16, 2021
@cjihrig @targos
tools: update ESLint to 7.12.1
8e4a055 
Update ESLint to 7.12.1

PR-URL: #35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@cjihrig @targos
tools: update ESLint to 7.12.0
29d0840 
Update ESLint to 7.12.0

PR-URL: #35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
@cjihrig @targos
tools: update ESLint to 7.12.1
937fc0a 
Update ESLint to 7.12.1

PR-URL: #35799
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@targos targos removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@watilde watilde watilde approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjihrig @nodejs-github-bot @Trott @watilde @juanarbol @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.