GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in BUILDING.md by RaisinTen · Pull Request #35807 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Oct 26, 2020

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
doc: fix typo in BUILDING.md
d13340d
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Oct 26, 2020
richardlau
richardlau approved these changes Oct 26, 2020
View reviewed changes
watilde
watilde approved these changes Oct 26, 2020
View reviewed changes
Trott
Trott approved these changes Oct 26, 2020
View reviewed changes
gengjiawen
gengjiawen approved these changes Oct 26, 2020
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 26, 2020
aduh95
aduh95 approved these changes Oct 26, 2020
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Oct 26, 2020
View reviewed changes
@RaisinTen

RaisinTen commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

How may I fix this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@watilde

watilde commented Oct 26, 2020

Copy link
Copy Markdown
Member

As this PR fixes a typo, let me ask for 👍 to fast track.

@RaisinTen Basically we need to wait for 48h before we ship or get more than two 👍 from collaborators on this comment to quickly ship. Refs: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#waiting-for-approvals
gireeshpunathil, richardlau, aduh95, bcoe, RaisinTen, juanarbol, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 7 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@watilde watilde added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 26, 2020
@aduh95

aduh95 commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

How may I fix this?

@RaisinTen If you refer to the failing GitHub Action, don't worry it's just a flaky CI job that timed out. I've restarted the job, it should be fine now.
watilde, RaisinTen, and juanarbol reacted with heart emoji
All reactions
  • ❤️ 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen

RaisinTen commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

@watilde @aduh95 thanks for the clarification and the re-run 🙂
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol
juanarbol approved these changes Oct 26, 2020
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaisinTen Thanks for your contribution. This is awesome!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
lpinca
lpinca approved these changes Oct 26, 2020
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33871/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol

juanarbol commented Oct 26, 2020

Copy link
Copy Markdown
Member

@lpinca This is a doc-only change, this does not require a full CI-job, with green actions is enough. I think this can be landed as it is now (?).
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@watilde watilde added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2020
@github-actions

github-actions Bot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Landed in 9ff25b1...ed5e539
juanarbol and RaisinTen reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Oct 27, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
@RaisinTen @nodejs-github-bot
doc: fix typo in BUILDING.md
ed5e539 
PR-URL: #35807
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 3, 2020
@RaisinTen @targos
doc: fix typo in BUILDING.md
c365867 
PR-URL: #35807
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
v15.1.0 release proposal #35948
Merged
@RaisinTen
RaisinTen deleted the doc/fix-typo-in-BUILDING.md branch November 10, 2020 07:10
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@RaisinTen @BethGriggs
doc: fix typo in BUILDING.md
384d518 
PR-URL: #35807
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen @BethGriggs
doc: fix typo in BUILDING.md
956fdc7 
PR-URL: #35807
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
targos pushed a commit that referenced this pull request Mar 3, 2021
@RaisinTen @targos
doc: fix typo in BUILDING.md
772afde 
PR-URL: #35807
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
@RaisinTen @MylesBorins
doc: fix typo in BUILDING.md
d1004d2 
PR-URL: #35807
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@watilde watilde watilde approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@aduh95 aduh95 aduh95 approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@RaisinTen @watilde @aduh95 @nodejs-github-bot @juanarbol @Trott @lpinca @gengjiawen @richardlau @gireeshpunathil
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.