GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add test to fs/promises setImmediate by tyankatsu0105 · Pull Request #35852 · nodejs/node

Conversation

@tyankatsu0105

@tyankatsu0105 tyankatsu0105 commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Added test pattern to setImmediate when ref's type is not boolean

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
watilde and bricss reacted with rocket emoji
All reactions
  • 🚀 2 reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 28, 2020
@yosuke-furukawa
yosuke-furukawa self-requested a review October 28, 2020 14:45
yosuke-furukawa
yosuke-furukawa approved these changes Oct 28, 2020
View reviewed changes
shisama
shisama approved these changes Oct 28, 2020
View reviewed changes
@shisama shisama added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 28, 2020
benjamingr
benjamingr approved these changes Oct 28, 2020
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 28, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33913/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Leko
Leko approved these changes Oct 28, 2020
View reviewed changes
watilde
watilde approved these changes Oct 28, 2020
View reviewed changes
rickyes
rickyes approved these changes Oct 29, 2020
View reviewed changes

@rickyes rickyes left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tyankatsu0105 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33929/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Oct 29, 2020
View reviewed changes
@Trott Trott mentioned this pull request Oct 29, 2020
timers: add non-boolean ref test setImmediate #35860
Closed
3 tasks done
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2020 •
edited by rickyes
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33931/ ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rickyes rickyes added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 31, 2020
@tyankatsu0105 @Trott
test: add test to fs/promises setImmediate
5dd344a 
Add test pattern to setImmediate when ref's type is not boolean

PR-URL: nodejs#35852
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Trott force-pushed the coverage/test-timers-promisifiled branch from b08259a to 5dd344a Compare October 31, 2020 11:48
@Trott
Trott merged commit 5dd344a into nodejs:master Oct 31, 2020
@Trott

Trott commented Oct 31, 2020

Copy link
Copy Markdown
Member

Landed in 5dd344a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 31, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉
tyankatsu0105 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tyankatsu0105
tyankatsu0105 deleted the coverage/test-timers-promisifiled branch October 31, 2020 14:59
targos pushed a commit that referenced this pull request Nov 3, 2020
@tyankatsu0105 @targos
test: add test to fs/promises setImmediate
66ad4be 
Add test pattern to setImmediate when ref's type is not boolean

PR-URL: #35852
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
v15.1.0 release proposal #35948
Merged
@MylesBorins MylesBorins added dont-land-on-v10.x labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@watilde watilde watilde approved these changes
+4 more reviewers
@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes
@Leko Leko Leko approved these changes
@shisama shisama shisama approved these changes
@rickyes rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@tyankatsu0105 @nodejs-github-bot @Trott @yosuke-furukawa @benjamingr @Leko @watilde @shisama @rickyes @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.