GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update to [email protected] by guybedford · Pull Request #35901 · nodejs/node

Conversation

@guybedford

@guybedford guybedford commented Oct 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This updates to [email protected], with the patches to improve the getter detection over the previous global opt-out of getters to specifically match the exact forms used by the Babel (and RollupJS and other build tool) getter output for reexports in strict conversions, implemented in nodejs/cjs-module-lexer#25 and nodejs/cjs-module-lexer#26.

This fixes the regression in #35893.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford guybedford mentioned this pull request Oct 31, 2020
SyntaxError: Named export not found starting v16.0.0-nightly20201030 #35893
Closed
@guybedford

guybedford commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

I'd like to request a fast track for this PR.
guybedford, MylesBorins, aduh95, and Trott reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34001/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford

guybedford commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

Ping @nodejs/modules-active-members for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Oct 31, 2020

Copy link
Copy Markdown
Contributor

This fixes the regression in #35893.

I'm still able to reproduce the related issue when applying the patch from this PR… Am I missing something?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford
deps: update to [email protected]
29056dd
@guybedford
guybedford force-pushed the lexer-update branch from 5d62a28 to 29056dd Compare October 31, 2020 18:46
@guybedford guybedford changed the title deps: update to [email protected] deps: update to [email protected] Oct 31, 2020
@guybedford

guybedford commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

@aduh95 thanks so much for checking this, I've updated the PR to a 0.5.2 supporting named getter functions, it's working now for the example I can confirm.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34002/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Oct 31, 2020

Copy link
Copy Markdown
Contributor

Yes, I can confirm the new version solves the issue 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Oct 31, 2020
View reviewed changes
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 31, 2020
Trott
Trott approved these changes Nov 1, 2020
View reviewed changes
guybedford added a commit that referenced this pull request Nov 1, 2020
@guybedford
deps: update to [email protected]
5735525 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@guybedford

guybedford commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 5735525.
MylesBorins reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford guybedford closed this Nov 1, 2020
@guybedford
guybedford deleted the lexer-update branch November 1, 2020 01:43
targos pushed a commit that referenced this pull request Nov 3, 2020
@guybedford @targos
deps: update to [email protected]
1303a1f 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
v15.1.0 release proposal #35948
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@guybedford @MylesBorins
deps: update to [email protected]
72b1ef8 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@guybedford @MylesBorins
deps: update to [email protected]
0a12e9d 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
v12.20.0 proposal #35950
Merged
BethGriggs pushed a commit that referenced this pull request Nov 16, 2020
@guybedford @BethGriggs
deps: update to [email protected]
0356963 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@guybedford @MylesBorins
deps: update to [email protected]
bdcc77b 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@guybedford @nodejs-github-bot @aduh95 @Trott
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.