GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update benchmark CI test indicator in README by Trott · Pull Request #35945 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 3, 2020

Copy link
Copy Markdown
Member

As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 3, 2020
richardlau
richardlau approved these changes Nov 3, 2020
View reviewed changes
watilde
watilde approved these changes Nov 3, 2020
View reviewed changes
lpinca
lpinca approved these changes Nov 3, 2020
View reviewed changes
@Trott
doc: update benchmark CI test indicator in README
c575aec 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: nodejs#35945
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the bm-test branch from 62e8381 to c575aec Compare November 5, 2020 13:53
@Trott

Trott commented Nov 5, 2020

Copy link
Copy Markdown
Member Author

Landed in c575aec
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit c575aec into nodejs:master Nov 5, 2020
@Trott
Trott deleted the bm-test branch November 5, 2020 13:53
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@Trott @danielleadams
doc: update benchmark CI test indicator in README
6d56ba0 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
v15.2.0 proposal #36055
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@Trott @BethGriggs
doc: update benchmark CI test indicator in README
7f0843b 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
doc: update benchmark CI test indicator in README
cf58d2f 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
doc: update benchmark CI test indicator in README
773685c 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@watilde watilde watilde approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @lpinca @watilde @richardlau @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.