GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: replace finally with PromisePrototypeFinally by baruchiro · Pull Request #35995 · nodejs/node

Conversation

@baruchiro

@baruchiro baruchiro commented Nov 6, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See suggestion here- #35993 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to file-system APIs and the fs module. label Nov 6, 2020
@baruchiro baruchiro mentioned this pull request Nov 6, 2020
fs: support abortsignal in writeFile #35993
Closed
benjamingr
benjamingr reviewed Nov 6, 2020
View reviewed changes
Comment thread lib/internal/fs/promises.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

If you could change other .finally calls in this file as well, that'd be nice.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@baruchiro
baruchiro force-pushed the patch-1 branch from a6ca29c to 1445352 Compare November 7, 2020 19:52
@baruchiro

baruchiro commented Nov 7, 2020

Copy link
Copy Markdown
Contributor Author

Sorry for the force push, I following the commit guidelines now (I hope)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@baruchiro baruchiro changed the title Suggested refactor by #35993 fs: replace finally with PromisePrototypeFinally Nov 7, 2020
@aduh95

aduh95 commented Nov 7, 2020

Copy link
Copy Markdown
Contributor

@baruchiro Can you rebase to resolve the conflict please?

git fetch upstream master
git rebase upstream/master -i
baruchiro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@baruchiro
fs: replace finally with PromisePrototypeFinally
b3d82e0 
nodejs#35993 (comment)
@baruchiro
baruchiro force-pushed the patch-1 branch from 53081c5 to b3d82e0 Compare November 8, 2020 07:52
@baruchiro

baruchiro commented Nov 8, 2020

Copy link
Copy Markdown
Contributor Author

About initializing the workspace and running vcbuild test, I found a bug in the vcbuild.bat file related to *Visual Studio 19 Preview`, I have one fix for that (but it not solving the whole process).

Where should I open a bug and/or PR for that?

(PR will be here, of course... But should I open an issue first? Do I need to open the issue in the current repo, even if it not related to node itself, but to the repo itself?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

Where should I open a bug and/or PR for that?

If you have a fix, PR is very welcome. Issue is not necessary if your PR describes the problem and the solution.
baruchiro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 8, 2020
aduh95
aduh95 approved these changes Nov 8, 2020
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 8, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 8, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2020 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34203/ ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Nov 8, 2020
View reviewed changes
@baruchiro

baruchiro commented Nov 9, 2020

Copy link
Copy Markdown
Contributor Author

@benjamingr As first-time contributor I allow myself to ask "what now?"

When this PR will be merged?
Do I need to do something?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

@baruchiro Your PR is author ready, that means you don't have anything left to do :) You just have to wait for someone landing it for you on master. You can read more about what's the process here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#accepting-modifications
baruchiro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 9, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 9, 2020
@github-actions

github-actions Bot commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Landed in 36fbbe0...a8b9ede
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Nov 9, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
@baruchiro @nodejs-github-bot
fs: replace finally with PromisePrototypeFinally
a8b9ede 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@baruchiro

baruchiro commented Nov 9, 2020

Copy link
Copy Markdown
Contributor Author

@aduh95 So it actually taked my commits into master, but not by the Github PR interface?

Interesting technique 😀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

@baruchiro yes, the reasons are outlined here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#landing-pull-requests

But anyway, you are now officially a Node.js contributor, congrats 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@baruchiro
baruchiro deleted the patch-1 branch November 9, 2020 19:15
@baruchiro

baruchiro commented Nov 9, 2020

Copy link
Copy Markdown
Contributor Author

Hooray!! 🥇

But now I can't write that in my CV, because I don't know how to answer the question "What you did as a Node.js contributor?"... 😉😉

Never mind, I'm sure the next contribution I will understand more. I just need to find the next one.
benjamingr and aduh95 reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Nov 9, 2020

Copy link
Copy Markdown
Member

Feel free to ping me on Facebook for more contribution ideas :)
baruchiro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@baruchiro @danielleadams
fs: replace finally with PromisePrototypeFinally
7ef9c70 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 10, 2020
v15.2.0 proposal #36055
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@baruchiro @BethGriggs
fs: replace finally with PromisePrototypeFinally
1ed0a03 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro @BethGriggs
fs: replace finally with PromisePrototypeFinally
affa710 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@baruchiro @BethGriggs
fs: replace finally with PromisePrototypeFinally
7c3b6f1 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr left review comments
@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fs Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@baruchiro @aduh95 @nodejs-github-bot @benjamingr @Trott
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.