GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: refactor to use more primordials by aduh95 · Pull Request #36024 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Nov 7, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@aduh95
module: refactor to use more primordials
1a93a9d
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Trott
Trott approved these changes Nov 7, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34179/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Nov 7, 2020
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 7, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 9, 2020
@github-actions

github-actions Bot commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Landed in a8b9ede...2c77fe1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Nov 9, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
@aduh95 @nodejs-github-bot
module: refactor to use more primordials
2c77fe1 
PR-URL: #36024
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@aduh95
aduh95 deleted the cjs-primordials branch November 9, 2020 19:07
danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@aduh95 @danielleadams
module: refactor to use more primordials
7a37590 
PR-URL: #36024
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 10, 2020
v15.2.0 proposal #36055
Merged
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
module: refactor to use more primordials
1f38c63 
PR-URL: #36024
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request May 19, 2021
@codebytere
module: refactor to use more primordials
688927d 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 19, 2021
@codebytere
module: refactor to use more primordials
5af0eb7 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 20, 2021
@codebytere
module: refactor to use more primordials
cad014e 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
c3e574b 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
3f33162 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
715f00f 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
4dbf9b6 
nodejs/node#36024
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
codebytere added a commit to electron/electron that referenced this pull request Jun 8, 2021
@codebytere
module: refactor to use more primordials
bb3b19c 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 8, 2021
@codebytere
module: refactor to use more primordials
3e6f3a5 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 9, 2021
@codebytere
module: refactor to use more primordials
05eb244 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 9, 2021
@codebytere
module: refactor to use more primordials
b51c59f 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 10, 2021
@codebytere
module: refactor to use more primordials
5d8d356 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 10, 2021
@codebytere
module: refactor to use more primordials
72b528e 
nodejs/node#36024
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
module: refactor to use more primordials
9e7f166 
PR-URL: #36024
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @Trott @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.