GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — win,build,tools: support VS prerelease by baruchiro · Pull Request #36033 · nodejs/node

Conversation

@baruchiro

@baruchiro baruchiro commented Nov 8, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

I don't know if we supporting prerelease (Preview) versions, but I see there is a flow for that, so I just adjust it.

Without my change, I have both Visual Studio 19 Preview and Visual Studio 17 Enterprise, but I getting the next error:

❯ .\vcbuild.bat
Looking for Python
Python found in C:\Users\BaruchR\AppData\Local\Programs\Python\Python37\\python.exe
Looking for NASM
Looking for Visual Studio 2019
Failed to find a suitable Visual Studio installation.
Try to run in a "Developer Command Prompt" or consult
https://github.com/nodejs/node/blob/master/BUILDING.md#windows

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. install Issues and PRs related to installing Node.js and its installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Nov 8, 2020
@targos

targos commented Nov 8, 2020

Copy link
Copy Markdown
Member

@nodejs/platform-windows
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 11, 2020

Copy link
Copy Markdown
Member

@nodejs/build-files
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 14, 2020

Copy link
Copy Markdown
Member

@nodejs/build
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@baruchiro @Trott
win,build,tools: support VS prerelease
a2ce6db
@Trott
Trott force-pushed the vsPrerelease branch from bfd392b to a2ce6db Compare November 17, 2020 20:40
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 17, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 17, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34446/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bzoz
bzoz approved these changes Nov 17, 2020
View reviewed changes

@bzoz bzoz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green CI, so LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34449/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Nov 19, 2020
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more comfortable giving this a 👍 now that there's approval from an actual Windows user/expert.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell
jasnell approved these changes Nov 19, 2020
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2020
@github-actions

github-actions Bot commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

Landed in 6312193...80a83d9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Nov 20, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2020
@baruchiro @nodejs-github-bot
win,build,tools: support VS prerelease
80a83d9 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@baruchiro
baruchiro deleted the vsPrerelease branch November 20, 2020 13:13
@Trott

Trott commented Nov 21, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉
baruchiro reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@baruchiro @codebytere
win,build,tools: support VS prerelease
4e3883e 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
v15.3.0 proposal #36232
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro @BethGriggs
win,build,tools: support VS prerelease
1b3935d 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro @BethGriggs
win,build,tools: support VS prerelease
e1b4bbf 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@baruchiro @BethGriggs
win,build,tools: support VS prerelease
c4c8541 
PR-URL: #36033
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
+1 more reviewer
@bzoz bzoz bzoz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. install Issues and PRs related to installing Node.js and its installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@baruchiro @targos @Trott @nodejs-github-bot @jasnell @bzoz @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.