GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: escape asterisk in cctest gtest-filter by RaisinTen · Pull Request #36034 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Nov 8, 2020

Copy link
Copy Markdown
Member

Some shells like zsh don't like it when the asterisks are not escaped in the command:

zsh: no matches found: --gtest_filter=EnvironmentTest.AtExit*

Escaping it makes it work both on zsh and bash.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@RaisinTen
doc: escape asterisk in cctest gtest-filter
d1de3ea
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 8, 2020
Trott
Trott approved these changes Nov 8, 2020
View reviewed changes
aduh95
aduh95 approved these changes Nov 8, 2020
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 8, 2020
aduh95 pushed a commit that referenced this pull request Nov 10, 2020
@RaisinTen @aduh95
doc: escape asterisk in cctest gtest-filter
9afe2b6
PR-URL: #36034
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95

aduh95 commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Landed in 9afe2b6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 closed this Nov 10, 2020
@RaisinTen
RaisinTen deleted the doc-escape-asterisk-cctest branch November 10, 2020 14:16
danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@RaisinTen @danielleadams
doc: escape asterisk in cctest gtest-filter
dcb2760
PR-URL: #36034
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 10, 2020
v15.2.0 proposal #36055
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@RaisinTen @BethGriggs
doc: escape asterisk in cctest gtest-filter
78ef866
PR-URL: #36034
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen @BethGriggs
doc: escape asterisk in cctest gtest-filter
f808543
PR-URL: #36034
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen @BethGriggs
doc: escape asterisk in cctest gtest-filter
6daf204
PR-URL: #36034
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RaisinTen @aduh95 @Trott @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.