GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — util: fix to inspect getters that access this by RaisinTen · Pull Request #36052 · nodejs/node

util: fix to inspect getters that access this #36052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Trott merged 1 commit into nodejs:master from RaisinTen:fix-util-inspect-getter

Nov 12, 2020

Uh oh!

There was an error while loading. Please reload this page.

Merged

util: fix to inspect getters that access this #36052

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

929c51f

util: fix to inspect getters that access this

RaisinTen Nov 9, 2020

File filter

Filter by extension .js (2) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

8 changes: 5 additions & 3 deletions 8 lib/internal/util/inspect.js

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -46,6 +46,7 @@ const {
		ObjectPrototypePropertyIsEnumerable,
		ObjectSeal,
		ObjectSetPrototypeOf,
		ReflectApply,
		RegExp,
		RegExpPrototypeToString,
		Set,
Expand Down Expand Up		@@ -627,7 +628,7 @@ function addPrototypeProperties(ctx, main, obj, recurseTimes, output) {
		continue;
		}
		const value = formatProperty(
		ctx, obj, recurseTimes, key, kObjectType, desc);
		ctx, obj, recurseTimes, key, kObjectType, desc, main);
		if (ctx.colors) {
		// Faint!
		output.push(`\u001b[2m${value}\u001b[22m`);
Expand Down Expand Up		@@ -1677,7 +1678,8 @@ function formatPromise(ctx, value, recurseTimes) {
		return output;
		}

		function formatProperty(ctx, value, recurseTimes, key, type, desc) {
		function formatProperty(ctx, value, recurseTimes, key, type, desc,
		original = value) {
		let name, str;
		let extra = ' ';
		desc = desc \|\| ObjectGetOwnPropertyDescriptor(value, key) \|\|
Expand All		@@ -1698,7 +1700,7 @@ function formatProperty(ctx, value, recurseTimes, key, type, desc) {
		(ctx.getters === 'get' && desc.set === undefined) \|\|
		(ctx.getters === 'set' && desc.set !== undefined))) {
		try {
		const tmp = value[key];
		const tmp = ReflectApply(desc.get, original, []);
		ctx.indentationLvl += 2;
		if (tmp === null) {
		str = `${s(`[${label}:`, sp)} ${s('null', 'null')}${s(']', sp)}`;
Expand Down

30 changes: 30 additions & 0 deletions 30 test/parallel/test-util-inspect-getters-accessing-this.js

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,30 @@
		'use strict';

		require('../common');

		// This test ensures that util.inspect logs getters
		// which access this.

		const assert = require('assert');

		const util = require('util');

		class X {
		constructor() {
		this._y = 123;
		}

		get y() {
		return this._y;
		}
		}

		const result = util.inspect(new X(), {
		getters: true,
		showHidden: true
		});

		assert.strictEqual(
		result,
		'X { _y: 123, [y]: [Getter: 123] }'
		);

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.