GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in `events.getEventListeners` example by Semigradsky · Pull Request #36085 · nodejs/node

Conversation

@Semigradsky

@Semigradsky Semigradsky commented Nov 11, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Semigradsky
doc: fix events.getEventListeners example
3670f19
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. labels Nov 11, 2020
lpinca
lpinca approved these changes Nov 11, 2020
View reviewed changes
benjamingr
benjamingr approved these changes Nov 11, 2020
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good catch!

API feedback welcome as well :]

If you want to find more places to contribute - this API could probably use a few more tests as well!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjamingr

benjamingr commented Nov 11, 2020

Copy link
Copy Markdown
Member

As this is a docs typo and a first time contributor:

👍 to fast track
benjamingr, ZYSzys, and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
ZYSzys
ZYSzys approved these changes Nov 11, 2020
View reviewed changes
aduh95
aduh95 approved these changes Nov 11, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34337/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 11, 2020
@github-actions github-actions Bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 11, 2020
@github-actions

github-actions Bot commented Nov 11, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36085
✔  Done loading data for nodejs/node/pull/36085
----------------------------------- PR info ------------------------------------
Title      doc: fix typo in `events.getEventListeners` example (#36085)
Author     Dmitry Semigradsky  (@Semigradsky, first-time contributor)
Branch     Semigradsky:patch-1 -> nodejs:master
Labels     author ready, doc, events
Commits    1
 - doc: fix `events.getEventListeners` example
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36085
Reviewed-By: Luigi Pinca 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36085
Reviewed-By: Luigi Pinca 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Wed, 11 Nov 2020 15:54:59 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36085#pullrequestreview-528307178
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36085#pullrequestreview-528329331
   ✔  - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/36085#pullrequestreview-528351605
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36085#pullrequestreview-528412376
   ✖  This PR needs to wait 45 more hours to land
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/358244318
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 11, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 11, 2020
@github-actions

github-actions Bot commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

Landed in c0ac692...a8b8b8b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Nov 11, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 11, 2020
@Semigradsky @nodejs-github-bot
doc: fix events.getEventListeners example
a8b8b8b 
PR-URL: #36085
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@benjamingr

benjamingr commented Nov 11, 2020

Copy link
Copy Markdown
Member

Congrats on your first contribution @Semigradsky 🎉 and a personal thanks for fixing my bug!
Semigradsky reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 1, 2021
@Semigradsky @targos
doc: fix events.getEventListeners example
ec140d7 
PR-URL: #36085
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Pranay180420 pushed a commit to Pranay180420/Node.jsforme that referenced this pull request Feb 17, 2025
@Semigradsky @targos
doc: fix events.getEventListeners example
b1f5518 
PR-URL: nodejs/node#36085
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Semigradsky @benjamingr @nodejs-github-bot @lpinca @aduh95 @ZYSzys
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.