GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix invalid link in worker_threads.md by Trott · Pull Request #36109 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 13, 2020

Copy link
Copy Markdown
Member

Inadvertent double hash in link makes it invalid and no longer pointing
to the document it intends to point to.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. worker Issues and PRs related to the worker_threads module and Worker API. labels Nov 13, 2020
aduh95
aduh95 approved these changes Nov 13, 2020
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Nov 13, 2020
View reviewed changes
richardlau
richardlau approved these changes Nov 13, 2020
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to catch this with the link checker?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Nov 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Is it possible to catch this with the link checker?

There may be edge cases, but I believe for any link we'd care about, more than one # character would be an error. So we should be able to flag it. For that matter, running this URL through new URL() would throw an error, so maybe that's a simple check we could add.
richardlau and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 13, 2020
View reviewed changes
ZYSzys
ZYSzys approved these changes Nov 13, 2020
View reviewed changes
watilde
watilde approved these changes Nov 14, 2020
View reviewed changes
@Trott
doc: fix invalid link in worker_threads.md
52666aa 
Inadvertent double hash in link makes it invalid and no longer pointing
to the documentation section it intends to point to.

PR-URL: nodejs#36109
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@Trott
Trott force-pushed the invalid-link branch from 7c1e887 to 52666aa Compare November 15, 2020 14:20
@Trott

Trott commented Nov 15, 2020

Copy link
Copy Markdown
Member Author

Landed in 52666aa
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 52666aa into nodejs:master Nov 15, 2020
@Trott
Trott deleted the invalid-link branch November 15, 2020 14:21
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@Trott @codebytere
doc: fix invalid link in worker_threads.md
e8a8513 
Inadvertent double hash in link makes it invalid and no longer pointing
to the documentation section it intends to point to.

PR-URL: #36109
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
v15.3.0 proposal #36232
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: fix invalid link in worker_threads.md
2d64947 
Inadvertent double hash in link makes it invalid and no longer pointing
to the documentation section it intends to point to.

PR-URL: #36109
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@watilde watilde watilde approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@aduh95 aduh95 aduh95 approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@Trott @lpinca @watilde @richardlau @gireeshpunathil @aduh95 @ZYSzys @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.