GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove empty name check in node_env_var.cc by RaisinTen · Pull Request #36133 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Nov 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The empty name check has been removed since this has landed:
libuv/libuv#2473

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 16, 2020
@RaisinTen
RaisinTen marked this pull request as ready for review November 16, 2020 13:51
@RaisinTen

RaisinTen commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

/CC @addaleax
Since the removal is related to your PR I thought it would be right to ping you. 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34481/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34503/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen requested a review from addaleax December 13, 2020 14:29
addaleax
addaleax reviewed Dec 13, 2020
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the still-relevant part of the comment is back :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/node_env_var.cc Outdated

@addaleax addaleax Dec 13, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure why this line is being removed, though?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@RaisinTen RaisinTen Dec 13, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I'll add that back in. Thanks for reviewing. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RaisinTen RaisinTen Dec 13, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
src: remove empty name check in node_env_var.cc
76ae744 
The empty name check has been removed since this has landed:
libuv/libuv#2473
@RaisinTen
RaisinTen force-pushed the update/empty-name-check-node_env_var.cc branch from 1206c69 to 76ae744 Compare December 13, 2020 14:37
addaleax
addaleax approved these changes Dec 13, 2020
View reviewed changes
@addaleax addaleax added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Dec 13, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 13, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34927/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 15, 2020
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 15, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 15, 2020
@github-actions

github-actions Bot commented Dec 15, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36133
✔  Done loading data for nodejs/node/pull/36133
----------------------------------- PR info ------------------------------------
Title      src: remove empty name check in node_env_var.cc (#36133)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:update/empty-name-check-node_env_var.cc -> nodejs:master
Labels     C++, author ready
Commits    1
 - src: remove empty name check in node_env_var.cc
Committers 1
 - raisinten 
PR-URL: https://github.com/nodejs/node/pull/36133
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36133
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2020-12-13T14:47:03Z: https://ci.nodejs.org/job/node-test-pull-request/34927/
- Querying data for job/node-test-pull-request/34927/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Mon, 16 Nov 2020 12:54:51 GMT
   ✔  Approvals: 2
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36133#pullrequestreview-550926817
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36133#pullrequestreview-552392117
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/423272881
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 15, 2020
jasnell
jasnell approved these changes Dec 15, 2020
View reviewed changes
@richardlau richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 15, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 15, 2020
@github-actions

github-actions Bot commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Landed in 6837a6d...5a637e9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Dec 15, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen @nodejs-github-bot
src: remove empty name check in node_env_var.cc
5a637e9 
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RaisinTen
RaisinTen deleted the update/empty-name-check-node_env_var.cc branch December 15, 2020 15:55
targos pushed a commit that referenced this pull request Dec 21, 2020
@RaisinTen @targos
src: remove empty name check in node_env_var.cc
68687d3 
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
v15.5.0 release proposal #36597
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
src: remove empty name check in node_env_var.cc
a356f32 
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@RaisinTen @nodejs-github-bot @jasnell @Trott @addaleax @richardlau @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.