GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Inadvertent disclosure by mhdawson · Pull Request #36155 · nodejs/node

Conversation

mhdawson commented Nov 17, 2020

Copy link

Copy Markdown

Member

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Nov 17, 2020 •

edited by mhdawson

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/tsc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label

Nov 17, 2020

cjihrig commented Nov 17, 2020

Copy link

Copy Markdown

Contributor

Are the n-api changes here intentional?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mmarchini reviewed

Nov 17, 2020

View reviewed changes

Comment thread

doc/guides/collaborator-guide.md Outdated

mmarchini Nov 17, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the repository? Or should we keep it without a link on purpose?

Also, I assume it will be a repo on nodejs-private?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson Nov 18, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not created the repo yet, but a link makes sense. It should only be accessible to those who have access to private repos within the org

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson Nov 18, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarchini added the link in the first reference, not sure if we need to make all references a link or not.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson Nov 18, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I assume it will be a repo on nodejs-private?

No, its a private repo in the nodejs org as I don't believe we can move issues across organizations.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mmarchini Nov 18, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The downside is that folks who have access to private repos in this org but not on the repo we usually use for security releases will have access to the issue. It's probably fine though, it only means some folks in moderation and CommComm will have access to the issue even when they don't have access to security release discussions (which is still better than keeping the issue public).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson Nov 19, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarchini

which is still better than keeping the issue public

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          doc: add process for handling premature disclosure

83c1c12

Add process for handling premature disclosure of
a security vulnerability in the public repos.

Signed-off-by: Michael Dawson <[email protected]>

mhdawson force-pushed the inadvertant-disclosure branch from 06b7d65 to 83c1c12 Compare

November 18, 2020 18:33

mhdawson commented

Nov 18, 2020

View reviewed changes

Comment thread

doc/guides/collaborator-guide.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mhdawson added 2 commits

November 18, 2020 13:36


          Update doc/guides/collaborator-guide.md

b11e4d5


          fixup

2d2004d

Flarna removed the c++ Issues and PRs that require attention from people who are familiar with C++. label

Nov 18, 2020

mhdawson added 3 commits

November 18, 2020 16:09


          squash: fixup

04c0058


          fixup

0e2c90c


          fixup

9a85ac9

richardlau reviewed

Nov 19, 2020

View reviewed changes

Comment thread

doc/guides/collaborator-guide.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/guides/collaborator-guide.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mcollina approved these changes

Nov 19, 2020

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson and others added 3 commits

November 20, 2020 10:50


          Update doc/guides/collaborator-guide.md

9bc5247

Co-authored-by: Richard Lau <[email protected]>


          Update doc/guides/collaborator-guide.md

c97676c

Co-authored-by: Richard Lau <[email protected]>


          fixup[

7e4de86

richardlau approved these changes

Nov 20, 2020

View reviewed changes

mmarchini approved these changes

Nov 20, 2020

View reviewed changes

mmarchini left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we need to open a request on nodejs/admin to create the repository, correct?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

doc/guides/collaborator-guide.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Trott approved these changes

Nov 22, 2020

View reviewed changes


          Update doc/guides/collaborator-guide.md

efe89c4

Co-authored-by: mary marchini <[email protected]>

mhdawson mentioned this pull request

Nov 23, 2020

Create private repo for inadvertent disclosures nodejs/admin#573

Closed

mhdawson commented Nov 23, 2020

Copy link

Copy Markdown

Member Author

@mmarchini good call on creating the request in admin. Here is the list: nodejs/admin#573

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson added a commit that referenced this pull request

Nov 30, 2020


          doc: add process for handling premature disclosure

9cf2341

Add process for handling premature disclosure of
a security vulnerability in the public repos.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36155
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

mhdawson commented Nov 30, 2020

Copy link

Copy Markdown

Member Author

Landed as 9cf2341

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson closed this

Nov 30, 2020

danielleadams pushed a commit that referenced this pull request

Dec 7, 2020


          doc: add process for handling premature disclosure

0401ffb

Add process for handling premature disclosure of
a security vulnerability in the public repos.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36155
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

danielleadams mentioned this pull request

Dec 7, 2020

v15.4.0 proposal #36435

Merged

targos pushed a commit that referenced this pull request

May 1, 2021


          doc: add process for handling premature disclosure

280d1b0

Add process for handling premature disclosure of
a security vulnerability in the public repos.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #36155
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

danielleadams mentioned this pull request

May 3, 2021

v14.17.0 proposal #38507

Merged

Reviewers

ljharb

ljharb left review comments

mcollina

mcollina approved these changes

Trott

Trott approved these changes

richardlau

richardlau approved these changes

+1 more reviewer

mmarchini

mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mhdawson commented Nov 17, 2020

Checklist

Uh oh!

nodejs-github-bot commented Nov 17, 2020 • edited by mhdawson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig commented Nov 17, 2020

Uh oh!

mmarchini Nov 17, 2020

Choose a reason for hiding this comment

Uh oh!

mhdawson Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

mhdawson Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

mhdawson Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

mmarchini Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

mhdawson Nov 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mmarchini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mhdawson commented Nov 23, 2020

Uh oh!

mhdawson commented Nov 30, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Nov 17, 2020 •

edited by mhdawson

Loading

Uh oh!

There was an error while loading. Please reload this page.