GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: update node.rc file description by devsnek · Pull Request #36197 · nodejs/node

Conversation

@devsnek

@devsnek devsnek commented Nov 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the name that appears in task manager by default

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2020
aduh95
aduh95 approved these changes Nov 20, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Nov 20, 2020
View reviewed changes
@devsnek devsnek added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. windows Issues and PRs related to the Windows platform. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels Nov 20, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Flarna
Flarna approved these changes Nov 20, 2020
View reviewed changes
addaleax
addaleax approved these changes Nov 20, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34492/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Nov 20, 2020
View reviewed changes
lpinca
lpinca approved these changes Nov 20, 2020
View reviewed changes
Trott
Trott approved these changes Nov 22, 2020
View reviewed changes
gengjiawen
gengjiawen approved these changes Nov 23, 2020
View reviewed changes
@devsnek devsnek added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 23, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 23, 2020
@github-actions

github-actions Bot commented Nov 23, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36197
✔  Done loading data for nodejs/node/pull/36197
----------------------------------- PR info ------------------------------------
Title      src: update node.rc file description (#36197)
Author     devsnek  (@devsnek)
Branch     devsnek:devsnek-patch-1 -> nodejs:master
Labels     lib / src, windows
Commits    1
 - src: update node.rc file description
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-11-20T19:56:01Z: https://ci.nodejs.org/job/node-test-pull-request/34492/
- Querying data for job/node-test-pull-request/34492/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 20 Nov 2020 15:42:19 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36197#pullrequestreview-535543556
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535567143
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/36197#pullrequestreview-535681875
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36197#pullrequestreview-535691143
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535738000
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36197#pullrequestreview-535767332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-536058722
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36197#pullrequestreview-536400270
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/379142842
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Nov 23, 2020
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 23, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 23, 2020
@github-actions

github-actions Bot commented Nov 23, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36197
✔  Done loading data for nodejs/node/pull/36197
----------------------------------- PR info ------------------------------------
Title      src: update node.rc file description (#36197)
Author     devsnek  (@devsnek)
Branch     devsnek:devsnek-patch-1 -> nodejs:master
Labels     lib / src, windows
Commits    1
 - src: update node.rc file description
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-11-23T14:48:32Z: https://ci.nodejs.org/job/node-test-pull-request/34492/
- Querying data for job/node-test-pull-request/34492/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 20 Nov 2020 15:42:19 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36197#pullrequestreview-535543556
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535567143
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/36197#pullrequestreview-535681875
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36197#pullrequestreview-535691143
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535738000
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36197#pullrequestreview-535767332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-536058722
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36197#pullrequestreview-536400270
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/379156320
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Nov 23, 2020
@devsnek
src: update node.rc file description
b5d9bd5 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@devsnek
devsnek force-pushed the devsnek-patch-1 branch from 7e47573 to b5d9bd5 Compare November 23, 2020 15:26
@devsnek
devsnek merged commit b5d9bd5 into master Nov 23, 2020
@devsnek

devsnek commented Nov 23, 2020

Copy link
Copy Markdown
Member Author

landed in b5d9bd5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
devsnek deleted the devsnek-patch-1 branch November 23, 2020 15:27
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@devsnek @danielleadams
src: update node.rc file description
47397ff 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
v15.4.0 proposal #36435
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@devsnek @targos
src: update node.rc file description
d8cb341 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@targos targos removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@aduh95 aduh95 aduh95 approved these changes
@Flarna Flarna Flarna approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@devsnek @nodejs-github-bot @Trott @addaleax @lpinca @targos @cjihrig @gengjiawen @aduh95 @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.