GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: adding example to Buffer.isBuffer method update buffer.md file by ntedgi · Pull Request #36233 · nodejs/node

Conversation

@ntedgi

@ntedgi ntedgi commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

update buffer.md file adding example to Buffer.isBuffer method

  • documentation is changed or added
  • commit message follows

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
ntedgi added 2 commits November 23, 2020 09:34
@ntedgi
doc : adding example to Buffer.isBuffer method update buffer.md file
05821e7
@ntedgi
remove description
55fcd43
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Nov 23, 2020
@ntedgi

ntedgi commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

following our conversion here at #36209 (comment)
I just update the example
@gireeshpunathil
gireeshpunathil reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntedgi
fix linting missing semi
31850dd
gireeshpunathil
gireeshpunathil approved these changes Nov 23, 2020
View reviewed changes
benjamingr
benjamingr reviewed Nov 23, 2020
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make these examples much shorter probably?

Buffer.isBuffer(Buffer.alloc(10)); // true
Buffer.isBuffer(Buffer.from('foo')); // true
Buffer.isBuffer('a string'); // false
Buffer.isBuffer([]); // false
Buffer.isBuffer(new Uint8Array(1024)); // false

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ntedgi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ntedgi
update review suggestions writing shorter tests
e4bd2e1
@ntedgi

ntedgi commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

I would make these examples much shorter probably?

Buffer.isBuffer(Buffer.alloc(10)); // true
Buffer.isBuffer(Buffer.from('foo')); // true
Buffer.isBuffer('a string'); // false
Buffer.isBuffer([]); // false
Buffer.isBuffer(new Uint8Array(1024)); // false

update according to your suggestions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntedgi
ntedgi requested a review from benjamingr November 23, 2020 11:22
benjamingr
benjamingr approved these changes Nov 23, 2020
View reviewed changes
lpinca
lpinca approved these changes Nov 23, 2020
View reviewed changes
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ntedgi
remove separat lines
10e4d5d
juanarbol
juanarbol approved these changes Nov 23, 2020
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is great!!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott approved these changes Nov 24, 2020
View reviewed changes
@gireeshpunathil gireeshpunathil added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 26, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 26, 2020
@github-actions

github-actions Bot commented Nov 26, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36233
✔  Done loading data for nodejs/node/pull/36233
----------------------------------- PR info ------------------------------------
Title      doc : adding example to Buffer.isBuffer method update buffer.md file  (#36233)
Author     Naor Tedgi (Abu Emma)  (@ntedgi, first-time contributor)
Branch     ntedgi:doc-buffer-static-method-buffer-isbuffer-obj-example -> nodejs:master
Labels     buffer, doc
Commits    5
 - doc : adding example to Buffer.isBuffer method update buffer.md file
 - remove description
 - fix linting missing semi
 - update review suggestions writing shorter tests
 - remove separat lines
Committers 1
 - naortedgi 
PR-URL: https://github.com/nodejs/node/pull/36233
Reviewed-By: Gireesh Punathil 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36233
Reviewed-By: Gireesh Punathil 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Mon, 23 Nov 2020 07:39:08 GMT
   ✔  Approvals: 5
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/36233#pullrequestreview-536237166
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36233#pullrequestreview-536386558
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36233#pullrequestreview-536406210
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/36233#pullrequestreview-536476851
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36233#pullrequestreview-537455462
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 36233
From https://github.com/nodejs/node
 * branch                  refs/pull/36233/merge -> FETCH_HEAD
✔  Fetched commits as 4c97325c4e33..10e4d5dc21a0
--------------------------------------------------------------------------------
[master 4c0c0f00c1] doc : adding example to Buffer.isBuffer method update buffer.md file
 Author: naortedgi 
 Date: Mon Nov 23 09:34:53 2020 +0200
 1 file changed, 20 insertions(+), 1 deletion(-)
[master 58dc655de5] remove description
 Author: naortedgi 
 Date: Mon Nov 23 09:37:19 2020 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[master 56af25f43c] fix linting missing semi
 Author: naortedgi 
 Date: Mon Nov 23 09:42:45 2020 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
[master 0a0b4a724d] update review suggestions writing shorter tests
 Author: naortedgi 
 Date: Mon Nov 23 13:05:47 2020 +0200
 1 file changed, 5 insertions(+), 15 deletions(-)
[master dd7f2e6801] remove separat lines
 Author: naortedgi 
 Date: Mon Nov 23 14:03:46 2020 +0200
 1 file changed, 2 deletions(-)
   ✔  Patches applied
There are 5 commits in the PR. Attempting autorebase.
Rebasing (2/10)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc : adding example to Buffer.isBuffer method update buffer.md file


PR-URL: #36233

Reviewed-By: Gireesh Punathil [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Juan José Arboleda [email protected]

Reviewed-By: Rich Trott [email protected]


[detached HEAD c1715ee8e4] doc : adding example to Buffer.isBuffer method update buffer.md file

Author: naortedgi [email protected]

Date: Mon Nov 23 09:34:53 2020 +0200

1 file changed, 20 insertions(+), 1 deletion(-)

Rebasing (3/10)

Rebasing (4/10)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

remove description


PR-URL: #36233

Reviewed-By: Gireesh Punathil [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Juan José Arboleda [email protected]

Reviewed-By: Rich Trott [email protected]


[detached HEAD a478068351] remove description

Author: naortedgi [email protected]

Date: Mon Nov 23 09:37:19 2020 +0200

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/10)

Rebasing (6/10)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix linting missing semi


PR-URL: #36233

Reviewed-By: Gireesh Punathil [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Juan José Arboleda [email protected]

Reviewed-By: Rich Trott [email protected]


[detached HEAD 2351660553] fix linting missing semi

Author: naortedgi [email protected]

Date: Mon Nov 23 09:42:45 2020 +0200

1 file changed, 2 insertions(+), 2 deletions(-)

Rebasing (7/10)

Rebasing (8/10)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

update review suggestions writing shorter tests


PR-URL: #36233

Reviewed-By: Gireesh Punathil [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Juan José Arboleda [email protected]

Reviewed-By: Rich Trott [email protected]


[detached HEAD cefb330868] update review suggestions writing shorter tests

Author: naortedgi [email protected]

Date: Mon Nov 23 13:05:47 2020 +0200

1 file changed, 5 insertions(+), 15 deletions(-)

Rebasing (9/10)

Rebasing (10/10)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

remove separat lines


PR-URL: #36233

Reviewed-By: Gireesh Punathil [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Juan José Arboleda [email protected]

Reviewed-By: Rich Trott [email protected]


[detached HEAD 081e05a2bc] remove separat lines

Author: naortedgi [email protected]

Date: Mon Nov 23 14:03:46 2020 +0200

1 file changed, 2 deletions(-)


Successfully rebased and updated refs/heads/master.

✔  c1715ee8e45305d74610d944646b4f63d46eb06d

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

⚠  0:50     Title should be <= 50 columns.            title-length

✖  a47806835142a1e9db9f43f30bde6fed6ef26fff

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Missing subsystem.                        subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

✖  235166055373514da12d98008b01a0ddf51f4c4b

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Missing subsystem.                        subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

✖  cefb3308685e649be2d448e81a0775c307ab6a74

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Missing subsystem.                        subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

✖  081e05a2bcca1b237f0bec36a30106e4b5340f03

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Missing subsystem.                        subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

ℹ  Please fix the commit message and try again.
https://github.com/nodejs/node/actions/runs/384668227
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Nov 26, 2020
@ntedgi ntedgi changed the title doc : adding example to Buffer.isBuffer method update buffer.md file doc: adding example to Buffer.isBuffer method update buffer.md file Nov 26, 2020
gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2020
@ntedgi @gireeshpunathil
doc: adding example to Buffer.isBuffer method
2b21a31 
PR-URL: #36233
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@gireeshpunathil

gireeshpunathil commented Nov 26, 2020

Copy link
Copy Markdown
Member

landed in 2b21a31 , thanks for the contribution! 🎉
benjamingr reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil closed this Nov 26, 2020
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@ntedgi @danielleadams
doc: adding example to Buffer.isBuffer method
65d89fd 
PR-URL: #36233
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
v15.4.0 proposal #36435
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@ntedgi @targos
doc: adding example to Buffer.isBuffer method
6201f23 
PR-URL: #36233
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@targos targos removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ntedgi @gireeshpunathil @Trott @benjamingr @lpinca @juanarbol @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.