GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky sequential/test-fs-watch by Trott · Pull Request #36249 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 24, 2020

Copy link
Copy Markdown
Member

Fixes: #36247

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 24, 2020
@Trott Trott added flaky-test Issues and PRs involving tests that fail intermittently in CI. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 24, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 24, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34540/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 24, 2020

Copy link
Copy Markdown
Member Author

Stress test: https://ci.nodejs.org/job/node-stress-single-test/206/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 24, 2020

Copy link
Copy Markdown
Member Author

I ran tools/test.py --repeat 1000 ./node test/sequential/test-fs-watch.js locally on master and on this PR. Master failed 4 times. This PR had no failures.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Nov 24, 2020
View reviewed changes
aduh95
aduh95 approved these changes Nov 24, 2020
View reviewed changes
@Trott

Trott commented Nov 25, 2020

Copy link
Copy Markdown
Member Author

Stress test: https://ci.nodejs.org/job/node-stress-single-test/206/

So this fixes the existing flakiness but introduces a different problem in that now it sometimes fails because it gets a rename event rather than a change event. That's another OS-specific weirdness thing but I'll see if we can get it to be consistently change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 25, 2020

Copy link
Copy Markdown
Member Author

Stress test: https://ci.nodejs.org/job/node-stress-single-test/207/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34545/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 25, 2020

Copy link
Copy Markdown
Member Author

That's another OS-specific weirdness thing but I'll see if we can get it to be consistently change.

The fixup commit fixed it locally and on CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Nov 25, 2020
View reviewed changes
@Trott
test: fix flaky sequential/test-fs-watch
8ba65b5 
Fixes: nodejs#36247

PR-URL: nodejs#36249
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott
Trott force-pushed the watch-interval branch from a28a2df to 8ba65b5 Compare November 27, 2020 13:01
@Trott

Trott commented Nov 27, 2020

Copy link
Copy Markdown
Member Author

Landed in 8ba65b5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 8ba65b5 into nodejs:master Nov 27, 2020
@Trott
Trott deleted the watch-interval branch November 27, 2020 13:03
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott @danielleadams
test: fix flaky sequential/test-fs-watch
2c7358e 
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
v15.4.0 proposal #36435
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: fix flaky sequential/test-fs-watch
b11e3ea 
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky sequential/test-fs-watch

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @nodejs-github-bot @joyeecheung @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.