GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add table header in intl.md by Trott · Pull Request #36261 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 25, 2020

Copy link
Copy Markdown
Member

An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 25, 2020
@Trott

Trott commented Nov 25, 2020

Copy link
Copy Markdown
Member Author

Before:
image

After:
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Nov 25, 2020
View reviewed changes
aduh95
aduh95 approved these changes Nov 25, 2020
View reviewed changes
richardlau
richardlau approved these changes Nov 25, 2020
View reviewed changes
jasnell
jasnell approved these changes Nov 25, 2020
View reviewed changes
lpinca
lpinca approved these changes Nov 25, 2020
View reviewed changes
Trott
Trott commented Nov 26, 2020
View reviewed changes
Comment thread doc/api/intl.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott
doc: add table header in intl.md
0ac2d0f 
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: nodejs#36261
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the th branch from 46f7773 to 0ac2d0f Compare November 28, 2020 13:14
@Trott

Trott commented Nov 28, 2020

Copy link
Copy Markdown
Member Author

Landed in 0ac2d0f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 0ac2d0f into nodejs:master Nov 28, 2020
@Trott
Trott deleted the th branch November 28, 2020 13:15
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott @danielleadams
doc: add table header in intl.md
3e5fcda 
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: #36261
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
v15.4.0 proposal #36435
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: add table header in intl.md
9269352 
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: #36261
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @jasnell @lpinca @joyeecheung @richardlau @aduh95 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.