GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update highlight.js to 10.1.2 by MylesBorins · Pull Request #36309 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Nov 28, 2020

Copy link
Copy Markdown
Contributor

Refs: GHSA-vfrc-7r7c-w9mx

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Nov 28, 2020
@MylesBorins

MylesBorins commented Nov 28, 2020

Copy link
Copy Markdown
Contributor Author

Can we please fast-track
aduh95, Trott, and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 28, 2020
@MylesBorins MylesBorins mentioned this pull request Nov 28, 2020
build(deps-dev): bump highlight.js from 10.1.0 to 10.1.2 in /tools/doc #36253
Closed
aduh95
aduh95 approved these changes Nov 28, 2020
View reviewed changes
@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 28, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 28, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34602/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Nov 29, 2020
View reviewed changes
@Trott

Trott commented Nov 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I ran make doc-only with and without this change (after running npm ci in the relevant directory) and there was no change to the resulting docs, so that's good.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Nov 29, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34614/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Nov 29, 2020

Copy link
Copy Markdown
Member

Looks good the CI was stuck and ran for 14 hours so I kicked off a new one
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34622/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins @Trott
tools: update highlight.js to 10.1.2
f34866a 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: nodejs#36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott
Trott force-pushed the update-highlight branch from 2058676 to f34866a Compare November 30, 2020 04:27
@Trott

Trott commented Nov 30, 2020

Copy link
Copy Markdown
Member

Landed in f34866a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit f34866a into nodejs:master Nov 30, 2020
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@MylesBorins @danielleadams
tools: update highlight.js to 10.1.2
d95ae65 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: #36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
v15.4.0 proposal #36435
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@MylesBorins @targos
tools: update highlight.js to 10.1.2
2677fe9 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: #36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MylesBorins @nodejs-github-bot @Trott @benjamingr @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.