GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix comment misspellings of transferred by Trott · Pull Request #36360 · nodejs/node

Conversation

@Trott

@Trott Trott commented Dec 3, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to Node.js core tests and test infrastructure. labels Dec 3, 2020
@Trott Trott mentioned this pull request Dec 3, 2020
src: use transferred consistently #36340
Closed
2 tasks done
danbev
danbev approved these changes Dec 3, 2020
View reviewed changes

@danbev danbev left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I only searched the src directory and should have searched everything.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Dec 3, 2020

Copy link
Copy Markdown
Member Author

Sorry, I only searched the src directory and should have searched everything.

I suppose. On the other hand, I'm OK with having src cleaned up in one PR and test in another, so...
¯\(ツ)/¯
danbev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 3, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 3, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34703/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65
himself65 approved these changes Dec 3, 2020
View reviewed changes
aduh95
aduh95 approved these changes Dec 3, 2020
View reviewed changes
watilde
watilde approved these changes Dec 3, 2020
View reviewed changes
richardlau
richardlau approved these changes Dec 3, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34727/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34749/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34766/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
test: fix comment misspellings of transferred
5122456 
PR-URL: nodejs#36360
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott
Trott force-pushed the transferred branch from 3f8581a to 5122456 Compare December 7, 2020 15:32
@Trott
Trott merged commit 5122456 into nodejs:master Dec 7, 2020
@Trott

Trott commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

Landed in 5122456
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the transferred branch December 7, 2020 15:51
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott @danielleadams
test: fix comment misspellings of transferred
b39d150 
PR-URL: #36360
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
v15.4.0 proposal #36435
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: fix comment misspellings of transferred
736b575 
PR-URL: #36360
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@watilde watilde watilde approved these changes
@richardlau richardlau richardlau approved these changes
@himself65 himself65 himself65 approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@danbev danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @nodejs-github-bot @danbev @watilde @richardlau @himself65 @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.