GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: increased externalized string length by codebytere · Pull Request #36451 · nodejs/node

Conversation

@codebytere

@codebytere codebytere commented Dec 9, 2020

Copy link
Copy Markdown
Member

Refs https://chromium-review.googlesource.com/c/v8/v8/+/2565511.

V8 has removed the ability to externalize internal external uncached strings via MakeExternal, as it is not thread-safe. This means that the examples that are in the test at present will begin to fail once Node.js rolls in the relevant CL, because their small size made them internal external uncached strings. This preemptively fixes the issue by making the strings bigger so they become internal & external & cached.

Electron hit and fixed this in electron/electron@0bf50b0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@codebytere
test: increased externalized string length
c4b6b70
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 9, 2020
@gireeshpunathil

gireeshpunathil commented Dec 9, 2020

Copy link
Copy Markdown
Member

@codebytere -

  • Is there a rule / definition on what makes up a small string?
  • does this mean small strings cannot be reliably used in Node.js?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 9, 2020
View reviewed changes
fhinkel
fhinkel approved these changes Dec 10, 2020
View reviewed changes
@codebytere codebytere mentioned this pull request Dec 10, 2020
chore: bump chromium to 096e5313aaf19dfa0c4710145c34d (master) electron/electron#26535
Merged
@codebytere

codebytere commented Dec 11, 2020

Copy link
Copy Markdown
Member Author

@gireeshpunathil unfortunately V8's bug tracker was pretty unclear about this - I couldn't find a specific minimum length specified. I don't believe this affects other aspects of Node.js beyond direct calls to externalizeString, no. The larger tracking bug is here: https://bugs.chromium.org/p/v8/issues/detail?id=7790 which may provide more insight?
gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Dec 12, 2020
View reviewed changes
@codebytere codebytere added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 12, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 12, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34914/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34915/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere

codebytere commented Dec 13, 2020

Copy link
Copy Markdown
Member Author

Landed in 7c702f8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere closed this Dec 13, 2020
codebytere added a commit that referenced this pull request Dec 13, 2020
@codebytere
test: increased externalized string length
7c702f8 
PR-URL: #36451
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@codebytere
codebytere deleted the up-externalized-string-length branch December 13, 2020 06:25
targos pushed a commit that referenced this pull request Dec 21, 2020
@codebytere @targos
test: increased externalized string length
acd78d9 
PR-URL: #36451
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
v15.5.0 release proposal #36597
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@codebytere @targos
test: increased externalized string length
44603b7 
PR-URL: #36451
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
@fhinkel fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@codebytere @gireeshpunathil @nodejs-github-bot @fhinkel @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.