GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: fix diagnostics_channel hasSubscribers error by Lxxyx · Pull Request #36599 · nodejs/node

Conversation

@Lxxyx

@Lxxyx Lxxyx commented Dec 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Related Issues

Fixes: #36598

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
RaisinTen
RaisinTen reviewed Dec 22, 2020
View reviewed changes
Comment thread lib/diagnostics_channel.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen

RaisinTen commented Dec 22, 2020

Copy link
Copy Markdown
Member

node/lib/diagnostics_channel.js

Line 95 in 656ce92

if (ref) channel = ref.get();

Should't this too be ref.deref()?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx

Lxxyx commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

node/lib/diagnostics_channel.js

Line 95 in 656ce92

if (ref) channel = ref.get();

Should't this too be ref.deref()?

WeakReference is export by internalBinding('util');, not WeakRef.
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx
Lxxyx force-pushed the fix-diagnostics_channel-error branch from 7429dce to 2294439 Compare December 22, 2020 15:30
aduh95
aduh95 approved these changes Dec 22, 2020
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
For reference, WeakRef is not available through primordials because it can be disable by the V8 flag --no-harmony-weak-refs (although using this flag crashes node, oh well).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Lxxyx and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Dec 22, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 22, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35047/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Dec 22, 2020
View reviewed changes
@lpinca

lpinca commented Dec 22, 2020

Copy link
Copy Markdown
Member

I think the subsystem in commit message should be "lib".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35048/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx

Lxxyx commented Dec 23, 2020

Copy link
Copy Markdown
Member Author

I think the subsystem in commit message should be "lib".

Thanks for the reply, but I'd like to know why the subsystem is lib but not diagnostics_channel.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Dec 23, 2020

Copy link
Copy Markdown
Member

My comment is based on previous commits like c6c36c3.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx Lxxyx changed the title diagnostics_channel: fix hasSubscribers error lib: fix diagnostics_channel hasSubscribers error Dec 23, 2020
@Lxxyx
Lxxyx force-pushed the fix-diagnostics_channel-error branch from 2294439 to 1390313 Compare December 23, 2020 06:37
@Lxxyx

Lxxyx commented Dec 23, 2020

Copy link
Copy Markdown
Member Author

My comment is based on previous commits like c6c36c3.

Thanks, the subsystem in commit message and pull request title is lib now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 23, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 23, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35052/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 23, 2020
View reviewed changes
@Trott

Trott commented Dec 24, 2020

Copy link
Copy Markdown
Member

Landed in 2d40e3f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 24, 2020
@Trott
Trott force-pushed the fix-diagnostics_channel-error branch from 1390313 to 2d40e3f Compare December 24, 2020 15:12
@Trott
Trott merged commit 2d40e3f into nodejs:master Dec 24, 2020
@Lxxyx
Lxxyx deleted the fix-diagnostics_channel-error branch December 24, 2020 15:24
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx @danielleadams
lib: fix diagnostics_channel hasSubscribers error
d20235b 
Fixes: #36598

PR-URL: #36599
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Lxxyx @targos
lib: fix diagnostics_channel hasSubscribers error
08b69fb 
Fixes: #36598

PR-URL: #36599
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@Mesteery Mesteery added the diagnostics_channel Issues and PRs related to the diagnostics_channel module. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTen RaisinTen RaisinTen left review comments
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. diagnostics_channel Issues and PRs related to the diagnostics_channel module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

diagnostics_channel: hasSubscribers throw TypeError: WeakRefPrototypeGet is not a function on Node 15.4.0

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Lxxyx @RaisinTen @nodejs-github-bot @lpinca @Trott @aduh95 @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.