GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: add simple https benchmark by puzpuzpuz · Pull Request #36612 · nodejs/node

Conversation

@puzpuzpuz

@puzpuzpuz puzpuzpuz commented Dec 23, 2020

Copy link
Copy Markdown
Member

It appears that we don't have any benchmarks for https. This PR aims to add a basic benchmark for https server implementation.

  • Adds a simple benchmark for https server based on the http simple benchmark.
  • Updates benchmarker integration for autocannon and wrk, so that they support https scheme.
  • Also adds a new HTTPS section and improves HTTP/2 section in the benchmark guide.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, aduh95, and ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@puzpuzpuz
benchmark: add simple https benchmark
459ad18 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.
@puzpuzpuz puzpuzpuz added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. https Issues and PRs related to the https subsystem. labels Dec 23, 2020
@puzpuzpuz puzpuzpuz mentioned this pull request Dec 23, 2020
https: refactor to use more primordials #36195
Closed
2 tasks done
aduh95
aduh95 reviewed Dec 24, 2020
View reviewed changes
Comment thread benchmark/fixtures/simple-https-server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 24, 2020
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 24, 2020
@Trott

Trott commented Dec 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

After this lands, we'll need https added to the choices in the CI benchmark job. (While we're at it, the options there are almost in alphabetical order. Should probably make it alphabetical too.) @nodejs/build
puzpuzpuz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 24, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35058/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@puzpuzpuz
fixup! benchmark: add simple https benchmark
6675aa0
@puzpuzpuz puzpuzpuz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 24, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 24, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 24, 2020 •
edited by puzpuzpuz
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35060/ (✅)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Dec 24, 2020
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 25, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 25, 2020
@github-actions

github-actions Bot commented Dec 25, 2020

Copy link
Copy Markdown
Contributor

Landed in 0187716...860c18b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Dec 25, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 25, 2020
@puzpuzpuz @nodejs-github-bot
benchmark: add simple https benchmark
860c18b 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@puzpuzpuz @danielleadams
benchmark: add simple https benchmark
7aedda9 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@puzpuzpuz @targos
benchmark: add simple https benchmark
3a11ee8 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. https Issues and PRs related to the https subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@puzpuzpuz @Trott @nodejs-github-bot @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.