GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — zlib: refactor to use primordial instead of <string>.startsWith by rchougule · Pull Request #36718 · nodejs/node

Conversation

@rchougule

@rchougule rchougule commented Jan 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Lxxyx reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the zlib Issues and PRs related to the zlib module and its compression dependencies. label Jan 1, 2021
Lxxyx
Lxxyx approved these changes Jan 1, 2021
View reviewed changes

@Lxxyx Lxxyx left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one nit.

I suggest the first word of the commit message should be an imperative verb, something like zlib: refactor to use primordials instead of StringPrototypeStartsWith. Refs: #36679 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rchougule reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@rchougule
zlib: refactor to use primordial instead of <string>.startsWith
0665753
@rchougule
rchougule force-pushed the zlib_string_primordials branch from fcf85c0 to 0665753 Compare January 1, 2021 12:59
@rchougule

rchougule commented Jan 1, 2021

Copy link
Copy Markdown
Contributor Author

LGTM except one nit.

I suggest the first word of the commit message should be an imperative verb, something like zlib: refactor to use primordials instead of StringPrototypeStartsWith. Refs: #36679 (comment)

Ah yes. My bad. Addressed in 0665753
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rchougule rchougule changed the title zlib: StringPrototypeStartsWith primordial instead of <string>.startsWith zlib: refactor to use primordial instead of <string>.startsWith Jan 1, 2021
aduh95
aduh95 approved these changes Jan 1, 2021
View reviewed changes
Comment thread lib/zlib.js
Comment on lines +790 to +792
(key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
constants[key] :
0)

@aduh95 aduh95 Jan 1, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I find it easier to read on one line, but you can leave it as is if you prefer.

Suggested change
(key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
constants[key] :
0)
(key) =>
(StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ? constants[key] : 0)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bl-ue reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
jasnell
jasnell approved these changes Jan 2, 2021
View reviewed changes
Trott
Trott approved these changes Jan 2, 2021
View reviewed changes
PoojaDurgad
PoojaDurgad approved these changes Jan 7, 2021
View reviewed changes
@yashLadha yashLadha added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 8, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 9, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35380/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35406/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha

yashLadha commented Jan 10, 2021

Copy link
Copy Markdown
Contributor

Landed in 7a6af02
rchougule reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha yashLadha closed this Jan 10, 2021
yashLadha pushed a commit that referenced this pull request Jan 10, 2021
@rchougule @yashLadha
zlib: refactor to use primordial instead of <string>.startsWith
7a6af02 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@rchougule
rchougule deleted the zlib_string_primordials branch January 10, 2021 09:17
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@rchougule @danielleadams
zlib: refactor to use primordial instead of <string>.startsWith
b6f74b0 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@rchougule @targos
zlib: refactor to use primordial instead of <string>.startsWith
161e805 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@rchougule @targos
zlib: refactor to use primordial instead of <string>.startsWith
a6aad06 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@rchougule @targos
zlib: refactor to use primordial instead of <string>.startsWith
0131ecf 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@rchougule @targos
zlib: refactor to use primordial instead of <string>.startsWith
740638d 
PR-URL: #36718
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@rchougule @nodejs-github-bot @yashLadha @jasnell @Trott @Lxxyx @aduh95 @PoojaDurgad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.