GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix typo by pmj642 · Pull Request #36719 · nodejs/node

Conversation

@pmj642

@pmj642 pmj642 commented Jan 1, 2021

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the http2 Issues and PRs related to the http2 subsystem. label Jan 1, 2021
Trott
Trott approved these changes Jan 1, 2021
View reviewed changes
watilde
watilde approved these changes Jan 1, 2021
View reviewed changes
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 1, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 1, 2021
yashLadha
yashLadha approved these changes Jan 1, 2021
View reviewed changes
@yashLadha

yashLadha commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Commit message can be improved though 😅 . Like using a substem http2: fix a typo error in comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha

yashLadha commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

@pmj642 You can amend and then force push it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pmj642

pmj642 commented Jan 1, 2021

Copy link
Copy Markdown
Contributor Author

@yashLadha I actually found one more typo in the same file, so I was thinking of adding it to the same PR.
yashLadha reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pmj642
pmj642 force-pushed the master branch from bd78c2e to 504c858 Compare January 1, 2021 16:43
@pmj642
http2: fix typos in core.js
fc68b93
@pmj642
pmj642 force-pushed the master branch from 504c858 to fc68b93 Compare January 1, 2021 16:44
jasnell
jasnell approved these changes Jan 2, 2021
View reviewed changes
@yashLadha yashLadha added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 2, 2021
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 3, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 3, 2021
yashLadha pushed a commit that referenced this pull request Jan 4, 2021
@pmj642 @yashLadha
http2: fix typos in core.js
8b8620d 
PR-URL: #36719
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@yashLadha

yashLadha commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

Landed in 8b8620d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha yashLadha closed this Jan 4, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@pmj642 @danielleadams
http2: fix typos in core.js
e85fbb7 
PR-URL: #36719
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@pmj642 @targos
http2: fix typos in core.js
16a1650 
PR-URL: #36719
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@watilde watilde watilde approved these changes
+1 more reviewer
@yashLadha yashLadha yashLadha approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@pmj642 @yashLadha @jasnell @Trott @watilde @aduh95 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.