GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — zlib: refactor to avoid unsafe array iteration by aduh95 · Pull Request #36722 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Jan 1, 2021

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added the zlib Issues and PRs related to the zlib module and its compression dependencies. label Jan 1, 2021
rchougule
rchougule reviewed Jan 1, 2021
View reviewed changes
Comment thread lib/zlib.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 added the needs-benchmark-ci PRs that need a benchmark CI run. label Jan 1, 2021
@aduh95

aduh95 commented Jan 2, 2021

Copy link
Copy Markdown
Contributor Author

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/849/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95

aduh95 commented Jan 2, 2021

Copy link
Copy Markdown
Contributor Author

Benchmark didn't show any significant regression.

Details
                                                                        confidence improvement accuracy (*)    (**)   (***)
 zlib/createInflate.js n=100 chunkLen=1024 inputLen=16777216                            0.31 %       ±5.68%  ±7.56%  ±9.84%
 zlib/creation.js n=500000 options='false' type='BrotliCompress'                       -1.14 %       ±4.72%  ±6.28%  ±8.18%
 zlib/creation.js n=500000 options='false' type='BrotliDecompress'                      0.60 %       ±4.53%  ±6.03%  ±7.86%
 zlib/creation.js n=500000 options='false' type='Deflate'                       **      5.07 %       ±3.77%  ±5.01%  ±6.52%
 zlib/creation.js n=500000 options='false' type='DeflateRaw'                            3.22 %       ±4.26%  ±5.68%  ±7.41%
 zlib/creation.js n=500000 options='false' type='Gunzip'                                0.84 %       ±3.61%  ±4.80%  ±6.25%
 zlib/creation.js n=500000 options='false' type='Gzip'                                  1.22 %       ±4.25%  ±5.68%  ±7.43%
 zlib/creation.js n=500000 options='false' type='Inflate'                               1.38 %       ±4.14%  ±5.51%  ±7.18%
 zlib/creation.js n=500000 options='false' type='InflateRaw'                            2.72 %       ±3.12%  ±4.15%  ±5.41%
 zlib/creation.js n=500000 options='false' type='Unzip'                                 0.11 %       ±3.68%  ±4.90%  ±6.39%
 zlib/creation.js n=500000 options='true' type='BrotliCompress'                        -0.32 %       ±4.39%  ±5.84%  ±7.61%
 zlib/creation.js n=500000 options='true' type='BrotliDecompress'                       3.16 %       ±4.11%  ±5.46%  ±7.11%
 zlib/creation.js n=500000 options='true' type='Deflate'                               -1.45 %       ±3.39%  ±4.51%  ±5.87%
 zlib/creation.js n=500000 options='true' type='DeflateRaw'                             2.96 %       ±4.09%  ±5.45%  ±7.09%
 zlib/creation.js n=500000 options='true' type='Gunzip'                          *      3.67 %       ±3.21%  ±4.27%  ±5.56%
 zlib/creation.js n=500000 options='true' type='Gzip'                                   1.18 %       ±3.66%  ±4.88%  ±6.35%
 zlib/creation.js n=500000 options='true' type='Inflate'                               -0.70 %       ±4.25%  ±5.66%  ±7.37%
 zlib/creation.js n=500000 options='true' type='InflateRaw'                      *     -3.95 %       ±3.94%  ±5.25%  ±6.83%
 zlib/creation.js n=500000 options='true' type='Unzip'                                 -0.03 %       ±5.02%  ±6.68%  ±8.70%
 zlib/deflate.js n=400000 inputLen=1024 method='createDeflate'                         -2.77 %       ±9.03% ±12.02% ±15.65%
 zlib/deflate.js n=400000 inputLen=1024 method='deflate'                                4.60 %       ±4.99%  ±6.64%  ±8.66%
 zlib/deflate.js n=400000 inputLen=1024 method='deflateSync'                            4.71 %       ±9.58% ±12.74% ±16.59%
 zlib/inflate.js n=400000 inputLen=1024 method='inflate'                               -0.84 %       ±2.95%  ±3.93%  ±5.11%
 zlib/inflate.js n=400000 inputLen=1024 method='inflateSync'                            1.52 %       ±4.60%  ±6.12%  ±7.96%
 zlib/pipe.js algorithm='brotli' type='buffer' duration=5 inputLen=1024                -0.77 %       ±2.11%  ±2.80%  ±3.65%
 zlib/pipe.js algorithm='brotli' type='string' duration=5 inputLen=1024                -0.17 %       ±1.01%  ±1.34%  ±1.74%
 zlib/pipe.js algorithm='gzip' type='buffer' duration=5 inputLen=1024                  -4.83 %       ±6.40%  ±8.52% ±11.10%
 zlib/pipe.js algorithm='gzip' type='string' duration=5 inputLen=1024                  -0.63 %       ±4.49%  ±5.98%  ±7.78%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 28 comparisons, you can thus
expect the following amount of false-positive results:
  1.40 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.28 false positives, when considering a   1% risk acceptance (**, ***),
  0.03 false positives, when considering a 0.1% risk acceptance (***)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 added dont-land-on-v10.x review wanted PRs that need review. and removed needs-benchmark-ci PRs that need a benchmark CI run. labels Jan 2, 2021
Trott
Trott approved these changes Jan 12, 2021
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 12, 2021
jasnell
jasnell approved these changes Jan 12, 2021
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 13, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35483/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35494/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

PoojaDurgad
PoojaDurgad approved these changes Jan 13, 2021
View reviewed changes
@aduh95
zlib: refactor to avoid unsafe array iteration
251a0ff
PR-URL: nodejs#36722
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@aduh95
aduh95 force-pushed the zlib-array-iteration branch from b7f6ee1 to 251a0ff Compare January 13, 2021 14:52
@aduh95

aduh95 commented Jan 13, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 251a0ff

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
aduh95 merged commit 251a0ff into nodejs:master Jan 13, 2021
@aduh95
aduh95 deleted the zlib-array-iteration branch January 13, 2021 14:52
@ruyadorno ruyadorno removed the review wanted PRs that need review. label Jan 21, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@aduh95 @ruyadorno
zlib: refactor to avoid unsafe array iteration
403b595
PR-URL: #36722
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
v15.7.0 proposal #37020
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@aduh95 @targos
zlib: refactor to avoid unsafe array iteration
5aa7666
PR-URL: #36722
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
zlib: refactor to avoid unsafe array iteration
16bb394
PR-URL: #36722
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
zlib: refactor to avoid unsafe array iteration
5b083ba
PR-URL: #36722
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
zlib: refactor to avoid unsafe array iteration
459fe68
PR-URL: #36722
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
+2 more reviewers
@rchougule rchougule rchougule left review comments
@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aduh95 @nodejs-github-bot @jasnell @Trott @rchougule @PoojaDurgad @ruyadorno
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.